Skip to content

Conversation

@kevinrizza
Copy link
Member

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 25, 2025

Hello @kevinrizza! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 25, 2025
@openshift-ci openshift-ci bot requested review from deads2k and everettraven March 25, 2025 20:37
@bertinatto
Copy link
Member

/test e2e-aws-serial
/test e2e-aws-serial-techpreview

1 similar comment
@kevinrizza
Copy link
Member Author

/test e2e-aws-serial
/test e2e-aws-serial-techpreview

@kevinrizza
Copy link
Member Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kevinrizza
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 24, 2025

@kevinrizza: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration 59a940b link true /test integration
ci/prow/e2e-aws-ovn-hypershift 59a940b link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-serial 59a940b link true /test e2e-aws-serial
ci/prow/verify 59a940b link true /test verify
ci/prow/e2e-aws-serial-techpreview 59a940b link true /test e2e-aws-serial-techpreview
ci/prow/e2e-aws-ovn 59a940b link true /test e2e-aws-ovn
ci/prow/verify-client-go 59a940b link true /test verify-client-go
ci/prow/okd-scos-e2e-aws-ovn 59a940b link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@damdo
Copy link
Member

damdo commented Jul 17, 2025

@kevinrizza @bertinatto was this superseded by #2252 ?

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 17, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bertinatto
Copy link
Member

@kevinrizza @bertinatto was this superseded by #2252 ?

Yup

/close

@openshift-ci openshift-ci bot closed this Jul 17, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 17, 2025

@bertinatto: Closed this PR.

In response to this:

@kevinrizza @bertinatto was this superseded by #2252 ?

Yup

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants