Skip to content

Conversation

@perdasilva
Copy link

The OLM team has decided to hold back the release of the Boxcutter integration from TechPreview for 4.21. This PR keeps the FeatureGate but removes it from all of the different profiles to avoid it showing up in the featuregates cluster resource and potentially confuse users.

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@openshift-ci-robot
Copy link

Pipeline controller notification
This repository is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 24, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 24, 2025

@perdasilva: This pull request references OPRUN-4002 which is a valid jira issue.

In response to this:

The OLM team has decided to hold back the release of the Boxcutter integration from TechPreview for 4.21. This PR keeps the FeatureGate but removes it from all of the different profiles to avoid it showing up in the featuregates cluster resource and potentially confuse users.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2025

Hello @perdasilva! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@coderabbitai
Copy link

coderabbitai bot commented Nov 24, 2025

Walkthrough

The NewOLMBoxCutterRuntime feature is being disabled across multiple platform configurations. The feature gate definition in code is modified to remove cluster profile gating, and corresponding feature gate manifests are updated to move the feature from enabled to disabled lists for specific profiles.

Changes

Cohort / File(s) Summary
Feature definition updates
features.md, features/features.go
Removed the enableForClusterProfile line from NewOLMBoxCutterRuntime feature gate, eliminating gating for SelfManaged, DevPreviewNoUpgrade, and TechPreviewNoUpgrade profiles; repositioned feature entry in list header.
Feature gate manifests
payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml, payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml
Moved NewOLMBoxCutterRuntime from enabled list to disabled list in feature gate status for both manifests.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Homogeneous changes across all files (consistent disabling pattern)
  • Straightforward edits with no complex logic
  • Single coherent purpose across modifications
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 88cca31 and 724606f.

📒 Files selected for processing (4)
  • features.md (1 hunks)
  • features/features.go (0 hunks)
  • payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml (1 hunks)
  • payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml (1 hunks)
💤 Files with no reviewable changes (1)
  • features/features.go
🧰 Additional context used
📓 Path-based instructions (1)
**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

  • payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml
  • features.md
  • payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml
🔇 Additional comments (3)
features.md (1)

8-8: Documentation correctly reflects feature gate disabled state.

Line 8 properly adds NewOLMBoxCutterRuntime to the feature gate table with all columns empty, indicating the feature is disabled across all profiles (Default, DevPreviewNoUpgrade, and TechPreviewNoUpgrade on both Hypershift and SelfManagedHA).

payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml (1)

35-37: Consistent feature gate disabling across DevPreviewNoUpgrade profile.

The change correctly mirrors the TechPreviewNoUpgrade variant by moving NewOLMBoxCutterRuntime to the disabled array. Verify that the parallel set of changes across TechPreviewNoUpgrade and DevPreviewNoUpgrade profiles is exhaustive and no other profile variants remain unupdated.

payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml (1)

47-49: All featuregate profiles are consistently updated—no issues found.

Verification confirms NewOLMBoxCutterRuntime is present and disabled in all 6 featuregate profile YAML files:

  • featureGate-Hypershift-Default.yaml ✓
  • featureGate-Hypershift-DevPreviewNoUpgrade.yaml ✓
  • featureGate-Hypershift-TechPreviewNoUpgrade.yaml ✓
  • featureGate-SelfManagedHA-Default.yaml ✓
  • featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml ✓
  • featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml ✓

No entries appear in enabled arrays. The PR implementation matches the stated objective to remove the feature from all profiles.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 24, 2025
@perdasilva perdasilva changed the title OPRUN-4002: Disable OLMv1 Boxcutter FeatureGate OPRUN-4281: Disable OLMv1 Boxcutter FeatureGate Nov 24, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 24, 2025

@perdasilva: This pull request references OPRUN-4281 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

The OLM team has decided to hold back the release of the Boxcutter integration from TechPreview for 4.21. This PR keeps the FeatureGate but removes it from all of the different profiles to avoid it showing up in the featuregates cluster resource and potentially confuse users.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2025
@openshift-ci-robot
Copy link

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2025
@bandrade
Copy link

/label qe-approved
/verified by @bandrade

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 24, 2025
@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 24, 2025
@openshift-ci-robot
Copy link

@bandrade: This PR has been marked as verified by @bandrade.

In response to this:

/label qe-approved
/verified by @bandrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 24, 2025

@perdasilva: This pull request references OPRUN-4281 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

The OLM team has decided to hold back the release of the Boxcutter integration from TechPreview for 4.21. This PR keeps the FeatureGate but removes it from all of the different profiles to avoid it showing up in the featuregates cluster resource and potentially confuse users.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 88cca31 and 2 for PR HEAD 724606f in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 999c45c and 1 for PR HEAD 724606f in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2025

@perdasilva: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit c11dd82 into openshift:master Nov 24, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants