Bug 1738401: config/ingress: clean up docs #402
Conversation
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@ironcladlou: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/XS
config/v1/types_ingress.go
Outdated
| // route's host name is empty. The generated host name will follow this | ||
| // pattern: "<route-name>.<route-namespace>.<domain>". | ||
| // | ||
| // Once set, domain cannot be updated. |
There was a problem hiding this comment.
@smarterclayton, this is true of ingresscontroller.spec.domain — is it also true here? ingress-operator won't actively observe the change, but the value will be used to drive the default domain for any ingresscontroller you create that lacks a .spec.domain value, so in that way it's honored, but it seems misleading to claim we support updating it in a deliberate/reasoned way at this point.
There was a problem hiding this comment.
Specify exactly what happens and what is supported.
There was a problem hiding this comment.
I added an additional point about another way in which the value is used, and clarified that changing the value is not supported.
openshift-ci-robot
added
size/S
|
@smarterclayton PTAL |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironcladlou, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@ironcladlou: All pull requests linked via external trackers have merged. The Bugzilla bug has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
No description provided.