Skip to content

Bug 1756141: Remove incorrect optional tag from new ingress field #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2019
Merged

Bug 1756141: Remove incorrect optional tag from new ingress field #448

merged 1 commit into from
Sep 27, 2019

Conversation

@ironcladlou
Copy link
Contributor

@ironcladlou ironcladlou commented Sep 26, 2019 •
edited
Loading

loadBalancer is a new field that contains scope, and loadBalancer is
optional (correct). However, loadBalancer.scope should be required. This
commit fixes that.

Backport of #446

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 26, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 26, 2019

@ironcladlou: This pull request references Bugzilla bug 1756141, which is invalid:

  • expected dependent Bugzilla bug 1756132 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1756141: Remove incorrect optional tag from new ingress field

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 26, 2019
@ironcladlou
Copy link
Contributor Author

ironcladlou commented Sep 26, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 26, 2019

@ironcladlou: This pull request references Bugzilla bug 1756141, which is invalid:

  • expected dependent Bugzilla bug 1756132 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 26, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 26, 2019

@ironcladlou: This pull request references Bugzilla bug 1756141, which is invalid:

  • expected dependent Bugzilla bug 1756132 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1756141: Remove incorrect optional tag from new ingress field

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 26, 2019

@ironcladlou: This pull request references Bugzilla bug 1756141, which is invalid:

  • expected dependent Bugzilla bug 1756132 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1756141: Remove incorrect optional tag from new ingress field

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ironcladlou
Copy link
Contributor Author

ironcladlou commented Sep 26, 2019

@deads2k @sttts not sure what's up with the protobuf changes that got emitted here. If they shouldn't have happened I can manually delete them for now rather than investigate why the local tooling produced the changes.

sttts
sttts reviewed Sep 27, 2019
View reviewed changes
quota/v1/generated.pb.go
import io "io"

// Reference imports to suppress errors if they are not otherwise used.
var _ = proto.Marshal
Copy link
Contributor

@sttts sttts Sep 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are many pb changes

Copy link
Contributor Author

@ironcladlou ironcladlou Sep 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually deleted these changes from the commit, not sure what's up with the generator. Will look into it later.

@ironcladlou
Bug 1756141: Remove incorrect optional tag from new ingress field
535221b 
`loadBalancer` is a new field that contains `scope`, and `loadBalancer` is
optional (correct). However, `loadBalancer.scope` _should_ be required. This
commit fixes that.
@knobunc
Copy link
Contributor

knobunc commented Sep 27, 2019

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 27, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ironcladlou, knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2019
@ironcladlou
Copy link
Contributor Author

ironcladlou commented Sep 27, 2019

@smarterclayton PTAL

@eparis
Copy link
Member

eparis commented Sep 27, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 27, 2019

@eparis: This pull request references Bugzilla bug 1756141, which is invalid:

  • expected dependent Bugzilla bug 1756132 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eparis
Copy link
Member

eparis commented Sep 27, 2019

I'm on my phone. Ben please go ahead and set cherry pick approved valid bug and unset invalid book

@knobunc knobunc added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 27, 2019
@openshift-merge-robot openshift-merge-robot merged commit d4a64ec into openshift:release-4.2 Sep 27, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 27, 2019

@ironcladlou: All pull requests linked via external trackers have merged. Bugzilla bug 1756141 has been moved to the MODIFIED state.

In response to this:

Bug 1756141: Remove incorrect optional tag from new ingress field

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

1 more reviewer

@sttts sttts sttts left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@knobunc knobunc

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ironcladlou @openshift-ci-robot @knobunc @eparis @sttts @openshift-merge-robot