Bug 1894268: Add v4 and v6 join subnets to ovn-kubernetes config #824

abhat · 2020-12-11T20:00:35Z

Some users need to be able to specify the v4 and v6 join subnets
to use for ovn-k. In particular, they may be already using the
ones that ovn-k uses as default, and they need a way to be able to
specify a different set of subnets as join subnets. This PR
creates the config option for the same. Eventually this will be
consumed by the CNO using rendered bootstrap data and passed
to the ovn-k daemonsets.

Signed-off-by: Aniket Bhat anbhat@redhat.com

openshift-ci-robot · 2020-12-11T20:00:54Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abhat
To complete the pull request process, please assign knobunc after the PR has been reviewed.
You can assign the PR to them by writing /assign @knobunc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

abhat · 2020-12-11T20:02:12Z

/assign @danwinship
cc @trozet

openshift-ci-robot · 2020-12-11T21:18:35Z

@abhat: This pull request references Bugzilla bug 1894268, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1894268: Add v4 and v6 join subnets to ovn-kubernetes config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

markdgray · 2020-12-14T10:40:12Z

operator/v1/0000_70_cluster-network-operator_01_crd.yaml

                        type: integer
                        format: int32
                        minimum: 0
+                      v4JoinSubnet:


Did you consider putting them in a sub-struct? e.g. Could there be other configuration needed for this?

i.e.
ovnKubernetesConfig:
joinSubnets:
v4: 100.65.0.0/16

I don't anticipate any other configuration which can fall under joinSubnets to make this as a sub-struct property.

markdgray · 2020-12-14T10:41:02Z

operator/v1/types_network.go

 	// cluster.
 	// +optional
 	IPsecConfig *IPsecConfig `json:"ipsecConfig,omitempty"`
+	// v4JoinSubnet is the v4 join subnet to be used by ovn-kubernetes in case the


I don't know what a "join subnet" is? Maybe it will be obvious to an administrator but you could add more description about that?

Good point. I will add more description about what a join subnet is.

mfojtik · 2020-12-14T12:09:51Z

/hold

This is post-feature-freeze API change, might require approval from @openshift/openshift-architects

knobunc · 2020-12-14T15:45:35Z

We'll hold this fix for the next release.

The join network is used inside ovn-kubernetes for the ip addresses for the logical join switches on each node. But if those addresses are not reachable outside the cluster we have effectively imposed another requirement on the operator of the cluster.

If that's the case, then I think we need to expose this, and indicate what it means (it can overlap with another cluster, the traffic will never be seen outside, but it can't be something that overlaps with a range the cluster is using, or with something the cluster will want to reach.

But I don't want to race this in to 4.7, we need to think about this.

Some users need to be able to specify the v4 and v6 join subnets to use for ovn-k. In particular, they may be already using the ones that ovn-k uses as default, and they need a way to be able to specify a different set of subnets as join subnets. This commit creates the config option for the same. Eventually this will be consumed by the CNO using rendered bootstrap data and passed to the ovn-k daemonsets. Signed-off-by: Aniket Bhat <anbhat@redhat.com>

danwinship · 2020-12-17T16:23:41Z

This is really an ugly implementation detail that no user should ever have to think about. It would be better if we could find some way to not need a separate CIDR for this. Like, maybe ovn-kubernetes could just use the highest-numbered subnet from the cluster network CIDR or something like that?

abhat · 2021-02-23T04:22:20Z

/hold cancel

abhat · 2021-02-23T15:11:21Z

@danwinship agreed it's an implementation detail that customer should not have to think about and ideally the knob should not be there. But we do allow for adding cluster CIDR and there is a potential for user-configured CIDR to step on the one we choose, unless CNO can validate addition of extra cluster CIDRs against the one we have allocated for the join subnet. Maybe all the logic can stay in CNO. wdyt?

/hold

danwinship · 2021-04-07T13:31:48Z

But we do allow for adding cluster CIDR and there is a potential for user-configured CIDR to step on the one we choose, unless CNO can validate addition of extra cluster CIDRs against the one we have allocated for the join subnet.

no, I mean, if you say

clusterNetworks:
  - cidr: 10.128.0.0/14
    hostPrefix: 23

then we assign 10.128.0.0/23 to the first node, and 10.128.2.0/23 to the second node and 10.128.4.0/23 to the third node, etc; the user isn't allowed to override this. And so I'm saying, can we just pre-allocate 10.131.254.0/23 (the last /23 in 10.128.0.0/14) for the join subnet? (For new clusters; for old clusters we keep using the old value.)

openshift-bot · 2021-07-06T20:09:47Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-ci · 2021-07-06T20:09:53Z

@abhat: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-08-05T23:56:19Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot · 2021-09-05T02:27:32Z

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · 2021-09-05T02:27:51Z

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-09-05T02:27:54Z

@abhat: This pull request references Bugzilla bug 1894268. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Bug 1894268: Add v4 and v6 join subnets to ovn-kubernetes config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from abhinavdahiya and deads2k December 11, 2020 20:00

openshift-ci-robot assigned danwinship Dec 11, 2020

abhat mentioned this pull request Dec 11, 2020

Bug 1894268: Join subnets openshift/cluster-network-operator#912

Closed

abhat changed the title ~~Add v4 and v6 join subnets to ovn-kubernetes config~~ Bug 1894268: Add v4 and v6 join subnets to ovn-kubernetes config Dec 11, 2020

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 11, 2020

markdgray reviewed Dec 14, 2020

View reviewed changes

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 14, 2020

abhat added 2 commits December 14, 2020 14:18

Update generated files

49b21e3

abhat force-pushed the join_subnets branch from 2d1fe3d to 49b21e3 Compare December 14, 2020 19:19

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2021

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2021

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 6, 2021

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2021

openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 5, 2021

openshift-ci bot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 5, 2021

openshift-ci bot closed this Sep 5, 2021

pliurh mentioned this pull request Jun 17, 2022

Bug 1894268: Allow users to specify ovnkube join subnet #1207

Merged

Bug 1894268: Add v4 and v6 join subnets to ovn-kubernetes config #824

Bug 1894268: Add v4 and v6 join subnets to ovn-kubernetes config #824

Uh oh!

Conversation

abhat commented Dec 11, 2020

Uh oh!

openshift-ci-robot commented Dec 11, 2020

Uh oh!

abhat commented Dec 11, 2020

Uh oh!

openshift-ci-robot commented Dec 11, 2020

Uh oh!

markdgray Dec 14, 2020

Choose a reason for hiding this comment

Uh oh!

abhat Dec 14, 2020

Choose a reason for hiding this comment

Uh oh!

markdgray Dec 14, 2020

Choose a reason for hiding this comment

Uh oh!

abhat Dec 14, 2020

Choose a reason for hiding this comment

Uh oh!

mfojtik commented Dec 14, 2020

Uh oh!

knobunc commented Dec 14, 2020

Uh oh!

danwinship commented Dec 17, 2020

Uh oh!

abhat commented Feb 23, 2021

Uh oh!

abhat commented Feb 23, 2021

Uh oh!

danwinship commented Apr 7, 2021

Uh oh!

openshift-bot commented Jul 6, 2021

Uh oh!

openshift-ci bot commented Jul 6, 2021

Uh oh!

openshift-bot commented Aug 5, 2021

Uh oh!

openshift-bot commented Sep 5, 2021

Uh oh!

openshift-ci bot commented Sep 5, 2021

Uh oh!

openshift-ci bot commented Sep 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants