ISSUE-368: Support disk by-path symlinks in deployment ISO#641
Conversation
|
@danielerez: No Jira issue with key ISSUE-368 exists in the tracker at https://issues.redhat.com/. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielerez The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Fixes the deployment ISO failing to clone the appliance disk image when using /dev/disk/by-path/* paths as the target device. The virt-resize command was failing with 'No such file or directory' because symlinks were not being properly resolved. Changes: - Wait for udev to settle before accessing disk paths - Wait up to 60 seconds for the target device to become available - Resolve symlinks to their actual device paths before passing to virt-resize - Add proper error handling when target device is not found - Add --pull=never to podman run to prevent TTY prompt errors - Tag loaded image to configured name to fix 'image not found' errors Fixes: openshift#368
danielerez
force-pushed
the
fix-disk-by-path-symlinks
branch
from
234f62f to
f7871d1
Compare
|
@danielerez: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick release-4.21 |
|
@danielerez: new pull request created: #710 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
Fixes the deployment ISO failing to clone the appliance disk image when using /dev/disk/by-path/* paths as the target device. The virt-resize command was failing with 'No such file or directory' because symlinks were not being properly resolved.
Changes:
Fixes: #368