ACM-33186: Revert Renovate configuration for Hive updates#2107
Conversation
|
@shay23bra: This pull request references ACM-33186 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThe Renovate configuration file is updated with reformatted array fields using multi-line JSON arrays for improved readability. Functionally, the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
renovate.json (1)
10-14: Please track a follow-up to restoregomodautomation.This revert is reasonable, but dependency update coverage for Go modules is now reduced. Please keep an owner/issue to re-enable it once MintMaker pseudo-version output is fixed.
Also applies to: 74-171
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@renovate.json` around lines 10 - 14, Re-add tracking to restore Go module automation: create a follow-up issue and assign an owner to re-enable the "gomod" manager in the renovate configuration (the "enabledManagers" array in renovate.json) once the MintMaker pseudo-version output is fixed; include the rationale, the current revert reference, and link to this PR, and note that the same change/issue should be applied to the other renovate.json blocks mentioned (lines ~74-171) so we remember to reintroduce "gomod" consistently across all configured manager lists.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@renovate.json`:
- Around line 10-14: Re-add tracking to restore Go module automation: create a
follow-up issue and assign an owner to re-enable the "gomod" manager in the
renovate configuration (the "enabledManagers" array in renovate.json) once the
MintMaker pseudo-version output is fixed; include the rationale, the current
revert reference, and link to this PR, and note that the same change/issue
should be applied to the other renovate.json blocks mentioned (lines ~74-171) so
we remember to reintroduce "gomod" consistently across all configured manager
lists.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 50f31fc1-b176-4655-9e83-d0911ecc2c3e
📒 Files selected for processing (1)
renovate.json
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2107 +/- ##
=======================================
Coverage 48.82% 48.82%
=======================================
Files 20 20
Lines 4397 4397
=======================================
Hits 2147 2147
Misses 2026 2026
Partials 224 224 🚀 New features to boost your workflow:
|
|
/override ci/prow/edge-e2e-ai-operator-ztp |
|
@gamli75: Overrode contexts on behalf of gamli75: ci/prow/edge-e2e-ai-operator-ztp DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gamli75, shay23bra The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@shay23bra: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Revert the Renovate/MintMaker configuration that enables hive/apis digest tracking.
MintMaker generates bare commit hashes instead of proper Go pseudo-versions,
which breaks go.mod.
Reverts changes from ACM-29247 / ACM-29261 / ACM-29244.
Summary by CodeRabbit