Skip to content

ACM-33186: Revert Renovate configuration for Hive updates#2107

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
shay23bra:ACM-33186-Revert-Renovate-configuration-for-Hive-updates-master
Apr 26, 2026
Merged

ACM-33186: Revert Renovate configuration for Hive updates#2107
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
shay23bra:ACM-33186-Revert-Renovate-configuration-for-Hive-updates-master

Conversation

@shay23bra
Copy link
Copy Markdown
Contributor

@shay23bra shay23bra commented Apr 23, 2026

Revert the Renovate/MintMaker configuration that enables hive/apis digest tracking.
MintMaker generates bare commit hashes instead of proper Go pseudo-versions,
which breaks go.mod.

Reverts changes from ACM-29247 / ACM-29261 / ACM-29244.

Summary by CodeRabbit

  • Chores
    • Disabled Go module dependency management from automated update configuration
    • Reorganized configuration structure for improved consistency and maintainability

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 23, 2026

@shay23bra: This pull request references ACM-33186 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Revert the Renovate/MintMaker configuration that enables hive/apis digest tracking.
MintMaker generates bare commit hashes instead of proper Go pseudo-versions,
which breaks go.mod.

Reverts changes from ACM-29247 / ACM-29261 / ACM-29244.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 23, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 23, 2026

Walkthrough

The Renovate configuration file is updated with reformatted array fields using multi-line JSON arrays for improved readability. Functionally, the gomod manager is removed from enabledManagers, its entire configuration block is deleted, and two related packageRules entries targeting the gomod manager are removed.

Changes

Cohort / File(s) Summary
Renovate Configuration
renovate.json
Reformatted array fields (labels, tekton.fileMatch, and multiple packageRules fields) to multi-line format. Removed gomod manager from enabledManagers, deleted the gomod manager configuration block with its postUpdateOptions, and removed two packageRules entries that targeted the gomod manager.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Stable And Deterministic Test Names ❌ Error Pull request contains Ginkgo test files with dynamic, non-deterministic test names using fmt.Sprintf() with variable values that violate stability requirements. Replace fmt.Sprintf() calls in test titles with static descriptive strings and move dynamic variable assertions into test bodies.
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and clearly describes the main change: reverting Renovate configuration for Hive updates, which matches the core purpose and content of the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Test Structure And Quality ✅ Passed PR only modifies renovate.json configuration file; no Ginkgo test code changes present.
Microshift Test Compatibility ✅ Passed PR only modifies renovate.json configuration file with no new Ginkgo e2e tests added, making MicroShift Test Compatibility check not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only modifies renovate.json configuration file and does not add or modify any Ginkgo e2e test files.
Topology-Aware Scheduling Compatibility ✅ Passed This pull request exclusively modifies the renovate.json dependency management configuration file. No Kubernetes deployment manifests, operator code, controllers, or scheduling constraints are introduced or modified.
Ote Binary Stdout Contract ✅ Passed The pull request only modifies the renovate.json configuration file and does not alter any Go source code, test files, or process-level code that could write to stdout.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only modifies renovate.json configuration file with no additions of new Ginkgo e2e tests, making this check inapplicable.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 23, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
renovate.json (1)

10-14: Please track a follow-up to restore gomod automation.

This revert is reasonable, but dependency update coverage for Go modules is now reduced. Please keep an owner/issue to re-enable it once MintMaker pseudo-version output is fixed.

Also applies to: 74-171

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@renovate.json` around lines 10 - 14, Re-add tracking to restore Go module
automation: create a follow-up issue and assign an owner to re-enable the
"gomod" manager in the renovate configuration (the "enabledManagers" array in
renovate.json) once the MintMaker pseudo-version output is fixed; include the
rationale, the current revert reference, and link to this PR, and note that the
same change/issue should be applied to the other renovate.json blocks mentioned
(lines ~74-171) so we remember to reintroduce "gomod" consistently across all
configured manager lists.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@renovate.json`:
- Around line 10-14: Re-add tracking to restore Go module automation: create a
follow-up issue and assign an owner to re-enable the "gomod" manager in the
renovate configuration (the "enabledManagers" array in renovate.json) once the
MintMaker pseudo-version output is fixed; include the rationale, the current
revert reference, and link to this PR, and note that the same change/issue
should be applied to the other renovate.json blocks mentioned (lines ~74-171) so
we remember to reintroduce "gomod" consistently across all configured manager
lists.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 50f31fc1-b176-4655-9e83-d0911ecc2c3e

📥 Commits

Reviewing files that changed from the base of the PR and between 25a3eed and d54e6fd.

📒 Files selected for processing (1)
  • renovate.json

@openshift-ci openshift-ci Bot requested review from danmanor and gamli75 April 23, 2026 12:56
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.82%. Comparing base (25a3eed) to head (d54e6fd).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2107   +/-   ##
=======================================
  Coverage   48.82%   48.82%           
=======================================
  Files          20       20           
  Lines        4397     4397           
=======================================
  Hits         2147     2147           
  Misses       2026     2026           
  Partials      224      224           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gamli75
Copy link
Copy Markdown
Contributor

gamli75 commented Apr 26, 2026

/override ci/prow/edge-e2e-ai-operator-ztp

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 26, 2026

@gamli75: Overrode contexts on behalf of gamli75: ci/prow/edge-e2e-ai-operator-ztp

Details

In response to this:

/override ci/prow/edge-e2e-ai-operator-ztp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 26, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, shay23bra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 26, 2026

@shay23bra: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 6f77cf5 into openshift:master Apr 26, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants