AGENT-1426: Add localhost mirror only when missing in IRI patcher

[danielerez]

When patching ImageDigestMirrorSet and ImageTagMirrorSet for InternalReleaseImage, append the localhost mirror only if the mirror set does not already contain a localhost entry (to avoid duplication).

This is required for: openshift/appliance#645 I.e. The appliance should use 'localhost', thus, already adding it to mirrors.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cf7f578e-aa5e-4570-8fbb-4f07d14cd682

📥 Commits

Reviewing files that changed from the base of the PR and between 0292c41 and a98d019.

📒 Files selected for processing (2)

• internal/ignition/internalreleaseimage_patcher.go
• internal/ignition/internalreleaseimage_patcher_test.go

---

Walkthrough

Added helper functions to detect whether an ImageMirror already targets localhost, and updated PatchManifests for both IDMS and ITMS to conditionally append localhost mirror entries only when not already present, while always appending api-int-patched entries. Comprehensive test coverage was added.

Changes

Cohort / File(s)	Summary
Mirror Detection and Conditional Patching internal/ignition/internalreleaseimage_patcher.go	Added mirrorHasLocalhost and mirrorsContainLocalhost helper functions to detect localhost targets (with or without port/path). Updated PatchManifests to conditionally append localhost mirror entries only when the original mirrors do not already contain a localhost entry, while always appending api-int-patched entries.
Mirror Detection and Patching Tests internal/ignition/internalreleaseimage_patcher_test.go	Added test specs validating localhost detection across various forms (no path, with port, with port/path) and non-localhost hosts. Added test case verifying PatchManifests does not add duplicate localhost mirrors to IDMS/ITMS when they already contain localhost entries. Included helper functions for base64-decoding and unmarshaling IDMS/ITMS manifests, plus fixture manifests with existing localhost mirrors.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can enforce grammar and style rules using `languagetool`.

Configure the reviews.tools.languagetool setting to enable/disable rules and categories. Refer to the LanguageTool Community to learn more.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@danielerez: This pull request references AGENT-1426 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

When patching ImageDigestMirrorSet and ImageTagMirrorSet for InternalReleaseImage, append the localhost mirror only if the mirror set does not already contain a localhost entry (to avoid duplication).

This is required for: openshift/appliance#645 I.e. The appliance should use 'localhost', thus, already adding it to mirrors.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[danielerez]

/test ?

[danielerez]

/test e2e-agent-compact-ipv4-iso-no-registry

[danielerez]

/cc @andfasano

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.49%. Comparing base (0292c41) to head (a98d019).
⚠️ Report is 14 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #10028      +/-   ##
==========================================
+ Coverage   44.09%   45.49%   +1.40%     
==========================================
  Files         415      415              
  Lines       72258    74599    +2341     
==========================================
+ Hits        31860    33939    +2079     
- Misses      37518    37756     +238     
- Partials     2880     2904      +24     

Files with missing lines	Coverage Δ
internal/ignition/internalreleaseimage_patcher.go	67.41% <100.00%> (+2.17%)	⬆️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[omer-vishlitzky]

/retest

[omer-vishlitzky]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielerez, omer-vishlitzky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [danielerez,omer-vishlitzky]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[omer-vishlitzky]

/retest

[danielerez]

/override ci/prow/edge-e2e-ai-operator-ztp

[openshift-ci]

@danielerez: Overrode contexts on behalf of danielerez: ci/prow/edge-e2e-ai-operator-ztp

Details

In response to this:

/override ci/prow/edge-e2e-ai-operator-ztp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[danielerez]

/override ci/prow/e2e-agent-compact-ipv4-iso-no-registry

[openshift-ci]

@danielerez: Overrode contexts on behalf of danielerez: ci/prow/e2e-agent-compact-ipv4-iso-no-registry

Details

In response to this:

/override ci/prow/e2e-agent-compact-ipv4-iso-no-registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@danielerez: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.