MGMT-23625: Remove pinned image version for nfd operator

[pastequo]

Remove pinned image version for NFD operator

• Slack discussion: https://redhat-internal.slack.com/archives/C041X004KGB/p1773855726557219
• access redhat solution: https://access.redhat.com/solutions/7104815

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Install a SNO cluster with NFD operator
After post-install, I checked the pods in openshift-nfd namespace, they are running just fine

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci-robot]

@pastequo: This pull request references MGMT-23625 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Remove pinned image version for NFD operator

• Slack discussion: https://redhat-internal.slack.com/archives/C041X004KGB/p1773855726557219
• access redhat solution: https://access.redhat.com/solutions/7104815

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e47d2c26-a179-4fae-9644-559322e2a103

📥 Commits

Reviewing files that changed from the base of the PR and between ec3e2e4 and c2f6dee.

📒 Files selected for processing (1)

• internal/operators/nodefeaturediscovery/templates/custom/nodefeaturediscovery.yaml

💤 Files with no reviewable changes (1)

• internal/operators/nodefeaturediscovery/templates/custom/nodefeaturediscovery.yaml

---

Walkthrough

Removed the pinned spec.operand.image field entry (including associated TODO comment and registry digest) from the NodeFeatureDiscovery custom resource template in the configuration file. The imagePullPolicy and servicePort settings remain intact.

Changes

Cohort / File(s)	Summary
NodeFeatureDiscovery Configuration internal/operators/nodefeaturediscovery/templates/custom/nodefeaturediscovery.yaml	Removed pinned spec.operand.image entry with TODO comment and digest from the custom resource template.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pastequo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [pastequo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pastequo]

/retest

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.36%. Comparing base (ec3e2e4) to head (c2f6dee).
⚠️ Report is 25 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #10045      +/-   ##
==========================================
+ Coverage   44.09%   45.36%   +1.27%     
==========================================
  Files         415      416       +1     
  Lines       72254    74591    +2337     
==========================================
+ Hits        31858    33839    +1981     
- Misses      37517    37807     +290     
- Partials     2879     2945      +66     

see 16 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[pastequo]

/retest

[pastequo]

/retest

[pastequo]

/override ci/prow/e2e-agent-compact-ipv4-iso-no-registry ci/prow/edge-e2e-ai-operator-ztp

[openshift-ci]

@pastequo: Overrode contexts on behalf of pastequo: ci/prow/e2e-agent-compact-ipv4-iso-no-registry, ci/prow/edge-e2e-ai-operator-ztp

Details

In response to this:

/override ci/prow/e2e-agent-compact-ipv4-iso-no-registry ci/prow/edge-e2e-ai-operator-ztp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[linoyaslan]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 7503bc0 and 2 for PR HEAD c2f6dee in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD acc8646 and 1 for PR HEAD c2f6dee in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d59c041 and 0 for PR HEAD c2f6dee in total

[openshift-ci-robot]

/hold

Revision c2f6dee was retested 3 times: holding

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d59c041 and 2 for PR HEAD c2f6dee in total

[pastequo]

/override ci/prow/e2e-agent-compact-ipv4

[openshift-ci]

@pastequo: Overrode contexts on behalf of pastequo: ci/prow/e2e-agent-compact-ipv4

Details

In response to this:

/override ci/prow/e2e-agent-compact-ipv4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@pastequo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.