MGMT-23920: 4.22 SNO doesn't support 4 cpu cores node by shay23bra · Pull Request #10153 · openshift/assisted-service

shay23bra · 2026-04-16T07:40:38Z

Summary by CodeRabbit

Bug Fixes
- Improved handling of pre-release version strings when matching hardware requirements so queries for pre-release builds map to the appropriate minimum-spec entry.
Tests
- Added test coverage for pre-release version scenarios to verify correct hardware requirement selection and prevent regressions.

…n matching

openshift-ci-robot · 2026-04-16T07:40:43Z

@shay23bra: This pull request references MGMT-23920 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-04-16T07:40:52Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7373c9e5-795b-459f-9424-005a5e329bfe

📥 Commits

Reviewing files that changed from the base of the PR and between 98ebd9a and 65536df.

📒 Files selected for processing (1)

internal/hardware/versioned-requirements.go

✅ Files skipped from review due to trivial changes (1)

internal/hardware/versioned-requirements.go

Walkthrough

Replaced direct parsing of the requested version with a base-version comparison when selecting min-version requirements; removed the goversion.NewVersion() guard. Added a test assertion ensuring a pre-release version (4.22.0-ec.5) resolves to the same min-version match.

Changes

Cohort / File(s)	Summary
Version Comparison Refactoring `internal/hardware/versioned-requirements.go`	Removed explicit `goversion.NewVersion()` parsing and its error guard in `GetVersionedHostRequirements()`; iterate min-version entries and use `common.BaseVersionGreaterOrEqual()` to select the first matching requirements.
Test Coverage Update `internal/hardware/versioned-requirements_test.go`	Added assertion that a pre-release version (`4.22.0-ec.5`) returns host requirements and matches the `4.22.x` min_version CPU cores value.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 8 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is completely empty, missing all required template sections including issue list, environment impact, testing details, and the mandatory checklist items.	Provide a complete PR description following the repository template: list the issue type (Bug fix), specify environment impact, confirm testing approach (No tests needed is acceptable), and complete all checklist items including title/description verification and documentation confirmation.
Test Structure And Quality	⚠️ Warning	Tests use generic Expect calls without descriptive failure messages; multiple scenarios encapsulated in single It blocks violate single-responsibility principle.	Refactor multi-scenario It blocks into separate tests; augment all Expect assertions with clear, actionable messages describing what failed.

✅ Passed checks (8 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'MGMT-23920: 4.22 SNO doesn't support 4 cpu cores node' clearly references the Jira issue and directly relates to the core problem being addressed: fixing CPU core support for 4.22 SNO deployments.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names	✅ Passed	All Ginkgo test names in the pull request are stable and deterministic with no dynamic content.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added in this pull request. The changes only modify unit tests using standard Go testing framework.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR does not add new Ginkgo e2e tests. It only extends an existing unit test with additional assertions to validate pre-release version string handling for hardware requirements configuration.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies hardware requirement lookup logic for pre-release version handling without introducing Kubernetes scheduling constraints, pod affinity rules, or topology-specific deployment configurations.
Ote Binary Stdout Contract	✅ Passed	Pull request modifies only internal library code in `internal/hardware` package and Ginkgo test blocks; no process-level code changes that would violate OTE Binary Stdout Contract.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR adds unit tests for hardware requirements configuration parsing, not e2e tests. These unit tests contain no IPv4 assumptions, hardcoded IP addresses, or external connectivity requirements.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2026-04-16T07:44:01Z

@shay23bra: This pull request references MGMT-23920 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary by CodeRabbit

Bug Fixes

Improved handling of pre-release version strings when matching hardware requirements, ensuring accurate mapping to appropriate specifications.

Tests

Added test coverage for pre-release version scenarios to verify correct hardware requirement selection.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pastequo · 2026-04-16T07:54:43Z

-					return copyVersionedHostRequirements(&d.minVersions[i].requirements), nil
-				}
+		for i := len(d.minVersions) - 1; i >= 0; i-- {
+			if isGreaterOrEqual, err := common.BaseVersionGreaterOrEqual(d.minVersions[i].requirements.Version, version); err == nil && isGreaterOrEqual {


It used to be LessThanOrEqual and now it's BaseVersionGreaterOrEqual is it expected ?
I checked myself the answer yes

It looks crazy that BaseVersionGreaterOrEqual reverses the order of parameter compared to VersionGreaterOrEqual...

codecov · 2026-04-16T08:01:21Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.33%. Comparing base (4d45d5f) to head (65536df).
⚠️ Report is 14 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #10153      +/-   ##
==========================================
+ Coverage   44.32%   44.33%   +0.01%     
==========================================
  Files         415      415              
  Lines       72765    72758       -7     
==========================================
+ Hits        32251    32257       +6     
+ Misses      37596    37587       -9     
+ Partials     2918     2914       -4

Files with missing lines	Coverage Δ
internal/hardware/versioned-requirements.go	`89.38% <100.00%> (-0.18%)`	⬇️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gamli75 · 2026-04-19T07:48:31Z

/override ci/prow/edge-e2e-metal-assisted-5-0

openshift-ci · 2026-04-19T07:48:46Z

@gamli75: Overrode contexts on behalf of gamli75: ci/prow/edge-e2e-metal-assisted-5-0

Details

In response to this:

/override ci/prow/edge-e2e-metal-assisted-5-0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2026-04-19T11:55:28Z

@shay23bra: This pull request references MGMT-23920 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "5.0." or "openshift-5.0.", but it targets "AI 2.52.1" instead.

Details

In response to this:

Summary by CodeRabbit

Bug Fixes

Improved handling of pre-release version strings when matching hardware requirements so queries for pre-release builds map to the appropriate minimum-spec entry.

Tests

Added test coverage for pre-release version scenarios to verify correct hardware requirement selection and prevent regressions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

shay23bra · 2026-04-19T17:48:58Z

/retest

gamli75 · 2026-04-20T05:51:15Z

/override ci/prow/edge-e2e-metal-assisted-5-0

openshift-ci · 2026-04-20T05:51:28Z

@gamli75: Overrode contexts on behalf of gamli75: ci/prow/edge-e2e-metal-assisted-5-0

Details

In response to this:

/override ci/prow/edge-e2e-metal-assisted-5-0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

pastequo · 2026-04-20T07:57:49Z

/lgtm

pastequo · 2026-04-20T09:46:57Z

/approve

openshift-ci · 2026-04-20T09:47:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pastequo, shay23bra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [pastequo,shay23bra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

shay23bra · 2026-04-20T09:54:27Z

/cherry-pick v2.52

openshift-cherrypick-robot · 2026-04-20T09:54:30Z

@shay23bra: once the present PR merges, I will cherry-pick it on top of v2.52 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick v2.52

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2026-04-20T12:46:53Z

@shay23bra: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-cherrypick-robot · 2026-04-20T12:52:54Z

@shay23bra: new pull request created: #10171

Details

In response to this:

/cherry-pick v2.52

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

use common.BaseVersionGreaterOrEqual for pre-release-aware min_versio…

98ebd9a

…n matching

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 16, 2026

openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 16, 2026

openshift-ci bot requested review from gamli75 and rccrdpccl April 16, 2026 07:41

pastequo reviewed Apr 16, 2026

View reviewed changes

Comment thread internal/hardware/versioned-requirements.go Outdated

pastequo reviewed Apr 16, 2026

View reviewed changes

remove redundant for loop

65536df

openshift-ci bot assigned pastequo Apr 20, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2026

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2026

openshift-merge-bot bot merged commit a51d691 into openshift:master Apr 20, 2026
23 checks passed

openshift-cherrypick-robot mentioned this pull request Apr 20, 2026

MGMT-23920: 4.22 SNO doesn't support 4 cpu cores node #10171

Open

Conversation

shay23bra commented Apr 16, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented Apr 16, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Apr 16, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

❌ Failed checks (2 warnings)

Uh oh!

openshift-ci-robot commented Apr 16, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

Uh oh!

pastequo Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gamli75 commented Apr 19, 2026

Uh oh!

openshift-ci bot commented Apr 19, 2026

Uh oh!

openshift-ci-robot commented Apr 19, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

shay23bra commented Apr 19, 2026

Uh oh!

gamli75 commented Apr 20, 2026

Uh oh!

openshift-ci bot commented Apr 20, 2026

Uh oh!

pastequo commented Apr 20, 2026

Uh oh!

pastequo commented Apr 20, 2026

Uh oh!

openshift-ci bot commented Apr 20, 2026

Uh oh!

shay23bra commented Apr 20, 2026

Uh oh!

openshift-cherrypick-robot commented Apr 20, 2026

Uh oh!

openshift-ci bot commented Apr 20, 2026

Uh oh!

Uh oh!

openshift-cherrypick-robot commented Apr 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

shay23bra commented Apr 16, 2026 •

edited by coderabbitai bot

Loading

openshift-ci-robot commented Apr 16, 2026 •

edited by openshift-ci bot

Loading

coderabbitai bot commented Apr 16, 2026 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Apr 16, 2026 •

edited by openshift-ci bot

Loading

codecov bot commented Apr 16, 2026 •

edited

Loading

openshift-ci-robot commented Apr 19, 2026 •

edited by openshift-ci bot

Loading