NO-ISSUE: [master] Bump OCP versions: 4.20, 4.21, 4.22, 4.18#10201
Conversation
|
@danmanor: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughUpdates OpenShift release image versions and URLs across multiple configuration files. Version 4.18 incremented to 4.18.38, 4.20 to 4.20.19, 4.21 to 4.21.11, and 4.22 transitioned from 4.22.0-ec.5 to 4.22.0-rc.0. Also removes trailing newline from one data file. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 11 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (11 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
openshift/template.yaml (1)
23-23: Consider generating this JSON from a single source of truth.
RELEASE_IMAGESis duplicated acrossdata/default_release_images.json,deploy/podman/configmap.yml, and this template. Auto-generation would reduce drift risk on future bumps.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@openshift/template.yaml` at line 23, The release images JSON is duplicated (seen as the value field in openshift/template.yaml and also in data/default_release_images.json and deploy/podman/configmap.yml); create a single source of truth (e.g., data/default_release_images.json) and change openshift/template.yaml to reference or inject that file during build/templating instead of hardcoding the JSON (replace the literal value in the value field with a templated include or build-time substitution), and update any deployment manifests (deploy/podman/configmap.yml) to consume the same generated artifact so all consumers of RELEASE_IMAGES are produced from the same generator (or add a small generation script invoked by CI/build to populate all three locations).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@openshift/template.yaml`:
- Line 23: The release images JSON is duplicated (seen as the value field in
openshift/template.yaml and also in data/default_release_images.json and
deploy/podman/configmap.yml); create a single source of truth (e.g.,
data/default_release_images.json) and change openshift/template.yaml to
reference or inject that file during build/templating instead of hardcoding the
JSON (replace the literal value in the value field with a templated include or
build-time substitution), and update any deployment manifests
(deploy/podman/configmap.yml) to consume the same generated artifact so all
consumers of RELEASE_IMAGES are produced from the same generator (or add a small
generation script invoked by CI/build to populate all three locations).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 1379b090-b5e1-46ac-8501-0732df686395
📒 Files selected for processing (4)
data/default_os_images.jsondata/default_release_images.jsondeploy/podman/configmap.ymlopenshift/template.yaml
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10201 +/- ##
=======================================
Coverage 44.34% 44.34%
=======================================
Files 415 415
Lines 72770 72770
=======================================
Hits 32270 32270
Misses 37584 37584
Partials 2916 2916 🚀 New features to boost your workflow:
|
|
@danmanor: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danmanor, gamli75 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
OpenShift updates: 4.22.0-ec.5-multi -> 4.22.0-rc.0-multi, 4.22.0-ec.5 -> 4.22.0-rc.0, 4.20.18-multi -> 4.20.19-multi, 4.20.18 -> 4.20.19, 4.21.10-multi -> 4.21.11-multi, 4.18.37 -> 4.18.38, 4.21.10 -> 4.21.11, 4.18.37-multi -> 4.18.38-multi
RHCOS updates:
/test edge-e2e-metal-assisted-4-20 edge-e2e-metal-assisted-4-21 edge-e2e-metal-assisted-4-22 edge-e2e-metal-assisted-4-18
/cc @rccrdpccl @gamli75
Summary by CodeRabbit