MGMT-20181: cleanup platform_oci and platform_external capabilities#7464
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@yoavsc0302: This pull request references MGMT-20181 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
size/M
|
@yoavsc0302: This pull request references MGMT-20181 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@yoavsc0302: This pull request references MGMT-20181 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
/test ? |
|
@adriengentil: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test edge-e2e-oci-assisted-4-18 |
adriengentil
left a comment
adriengentil
left a comment
There was a problem hiding this comment.
Looks good, thank you!
Let's wait for the two jobs I triggered above to pass, since this PR impacts them, then we'll be able to unhold this PR.
/hold
openshift-ci
Bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriengentil, yoavsc0302 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7464 +/- ##
==========================================
+ Coverage 67.40% 67.77% +0.37%
==========================================
Files 329 334 +5
Lines 42191 43295 +1104
==========================================
+ Hits 28437 29345 +908
- Misses 11182 11361 +179
- Partials 2572 2589 +17
🚀 New features to boost your workflow:
|
|
/test assisted-service-saas-main-on-pull-request |
|
@linoyaslan: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test assisted-service-rhel9-acm-ds-main-on-pull-request |
|
@linoyaslan: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
openshift-ci
Bot
added
the
ok-to-test
|
/unhold |
openshift-ci
Bot
removed
the
do-not-merge/hold
|
/retest |
1 similar comment
|
/retest |
|
@yoavsc0302: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-agent-installer-api-server |
6 participants
This PR removes code related to platform_oci and platform_external capabilities that are now enabled globally as specified in MGMT-20181.
Changes:
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs, README, etc)Reviewers Checklist