Skip to content

Conversation

@zszabo-rh
Copy link
Contributor

@zszabo-rh zszabo-rh commented Mar 27, 2025

ACM-19143: default osImages versions should be taken from supported-ocp-versions.json
Pls note that corresponding backplane version is 5 versions behind release-ocm version.

Commits:

  1. Main changes: data/default_os_images.json was modified, all other changes were generated.
  2. Necessary unit and subsystem tst modifications.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 27, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 27, 2025

@zszabo-rh: This pull request references ACM-19143 which is a valid jira issue.

Details

In response to this:

ACM-19143: default osImages versions should be taken from supported-ocp-versions.json
Pls note that corresponding backplane version is 5 versions behind release-ocm version.

data/default_os_images.json was modified, all other changes were generated.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 27, 2025
@openshift-ci openshift-ci bot requested review from carbonin and danmanor March 27, 2025 09:32
@zszabo-rh
Copy link
Contributor Author

/retest

@codecov
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.29%. Comparing base (b023d85) to head (8672b81).
Report is 3 commits behind head on release-ocm-2.10.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-ocm-2.10    #7466   +/-   ##
=================================================
  Coverage             68.28%   68.29%           
=================================================
  Files                   236      236           
  Lines                 35204    35204           
=================================================
+ Hits                  24040    24041    +1     
+ Misses                 9078     9077    -1     
  Partials               2086     2086           

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zszabo-rh
Copy link
Contributor Author

/retest

1 similar comment
@zszabo-rh
Copy link
Contributor Author

/retest

@zszabo-rh
Copy link
Contributor Author

/retest

1 similar comment
@zszabo-rh
Copy link
Contributor Author

/retest

@zszabo-rh zszabo-rh force-pushed the release-ocm-2.10 branch 3 times, most recently from b587d23 to 1aa331d Compare March 29, 2025 19:25
@zszabo-rh
Copy link
Contributor Author

/retest

@zszabo-rh zszabo-rh force-pushed the release-ocm-2.10 branch 2 times, most recently from b63577e to d2ce913 Compare March 31, 2025 10:12
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 1, 2025

@zszabo-rh: This pull request references ACM-19143 which is a valid jira issue.

Details

In response to this:

ACM-19143: default osImages versions should be taken from supported-ocp-versions.json
Pls note that corresponding backplane version is 5 versions behind release-ocm version.

Commits:

  1. Main changes: data/default_os_images.json was modified, all other changes were generated.
  2. Necessary unit and subsystem tst modifications.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@zszabo-rh
Copy link
Contributor Author

/retest

1 similar comment
@zszabo-rh
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2025
@openshift-ci
Copy link

openshift-ci bot commented Apr 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carbonin, zszabo-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 65b1868 and 2 for PR HEAD 8672b81 in total

@openshift-ci
Copy link

openshift-ci bot commented Apr 2, 2025

@zszabo-rh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit d2c5cd0 into openshift:release-ocm-2.10 Apr 2, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants