ACM-29247: (FIX) infrastructure operator set up renovate configuration to automatically create hive api synchronization p rs#9505
Conversation
|
No actionable comments were generated in the recent review. 🎉 WalkthroughAdds a packageRule to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
renovate.json (1)
105-110: Confirm gomod re-enable precedence in Renovate.Line 105-109 disables all
gomodupdates; if Renovate rule precedence doesn’t allow later rules to overrideenabled:false, the Hive API rule won’t take effect. Please verify with Renovate’s config validation/dry-run. If precedence isn’t guaranteed, consider excludinggithub.com/openshift/hive/apisfrom this disable rule to remove ordering dependence.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@renovate.json` around lines 105 - 110, The current Renovate rule sets "matchManagers": ["gomod"] with "enabled": false which will disable all gomod updates and may prevent the Hive API rule from applying; run Renovate's config validation/dry-run to confirm whether later rules can override this global disable, and if not, change this rule to either exclude the package "github.com/openshift/hive/apis" (e.g., via excludePackagePatterns/allowedManagers exception) or remove the blanket "enabled": false so the specific Hive API rule can take precedence; look for the rule object containing matchManagers: ["gomod"] to update and ensure the Hive API rule targeting github.com/openshift/hive/apis will be effective.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@renovate.json`:
- Around line 105-110: The current Renovate rule sets "matchManagers": ["gomod"]
with "enabled": false which will disable all gomod updates and may prevent the
Hive API rule from applying; run Renovate's config validation/dry-run to confirm
whether later rules can override this global disable, and if not, change this
rule to either exclude the package "github.com/openshift/hive/apis" (e.g., via
excludePackagePatterns/allowedManagers exception) or remove the blanket
"enabled": false so the specific Hive API rule can take precedence; look for the
rule object containing matchManagers: ["gomod"] to update and ensure the Hive
API rule targeting github.com/openshift/hive/apis will be effective.
|
/lgtm |
3644fa7 to
e6ac086
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giladravid16, shay23bra The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/jira refresh |
|
@giladravid16: This pull request references ACM-29247 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9505 +/- ##
==========================================
- Coverage 44.06% 44.05% -0.01%
==========================================
Files 414 414
Lines 72172 72172
==========================================
- Hits 31800 31795 -5
- Misses 37496 37499 +3
- Partials 2876 2878 +2 🚀 New features to boost your workflow:
|
|
@shay23bra: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Restrict renovate gomod manager to only update Hive API