Skip to content

ACM-29247: (FIX) infrastructure operator set up renovate configuration to automatically create hive api synchronization p rs#9505

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
shay23bra:ACM-29247-Infrastructure-Operator-Set-up-Renovate-configuration-to-automatically-create-Hive-API-Synchronization-PRs
Feb 18, 2026
Merged

ACM-29247: (FIX) infrastructure operator set up renovate configuration to automatically create hive api synchronization p rs#9505
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
shay23bra:ACM-29247-Infrastructure-Operator-Set-up-Renovate-configuration-to-automatically-create-Hive-API-Synchronization-PRs

Conversation

@shay23bra
Copy link
Contributor

Restrict renovate gomod manager to only update Hive API

@coderabbitai
Copy link

coderabbitai bot commented Feb 18, 2026

No actionable comments were generated in the recent review. 🎉


Walkthrough

Adds a packageRule to renovate.json that disables Renovate updates for the gomod manager by setting matchManagers: ["gomod"] and enabled: false.

Changes

Cohort / File(s) Summary
Renovate Configuration
renovate.json
Inserted a new packageRule object with matchManagers: ["gomod"] and enabled: false to disable gomod updates.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
renovate.json (1)

105-110: Confirm gomod re-enable precedence in Renovate.

Line 105-109 disables all gomod updates; if Renovate rule precedence doesn’t allow later rules to override enabled:false, the Hive API rule won’t take effect. Please verify with Renovate’s config validation/dry-run. If precedence isn’t guaranteed, consider excluding github.com/openshift/hive/apis from this disable rule to remove ordering dependence.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@renovate.json` around lines 105 - 110, The current Renovate rule sets
"matchManagers": ["gomod"] with "enabled": false which will disable all gomod
updates and may prevent the Hive API rule from applying; run Renovate's config
validation/dry-run to confirm whether later rules can override this global
disable, and if not, change this rule to either exclude the package
"github.com/openshift/hive/apis" (e.g., via
excludePackagePatterns/allowedManagers exception) or remove the blanket
"enabled": false so the specific Hive API rule can take precedence; look for the
rule object containing matchManagers: ["gomod"] to update and ensure the Hive
API rule targeting github.com/openshift/hive/apis will be effective.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@renovate.json`:
- Around line 105-110: The current Renovate rule sets "matchManagers": ["gomod"]
with "enabled": false which will disable all gomod updates and may prevent the
Hive API rule from applying; run Renovate's config validation/dry-run to confirm
whether later rules can override this global disable, and if not, change this
rule to either exclude the package "github.com/openshift/hive/apis" (e.g., via
excludePackagePatterns/allowedManagers exception) or remove the blanket
"enabled": false so the specific Hive API rule can take precedence; look for the
rule object containing matchManagers: ["gomod"] to update and ensure the Hive
API rule targeting github.com/openshift/hive/apis will be effective.

@pastequo
Copy link
Contributor

/lgtm

@shay23bra shay23bra force-pushed the ACM-29247-Infrastructure-Operator-Set-up-Renovate-configuration-to-automatically-create-Hive-API-Synchronization-PRs branch from 3644fa7 to e6ac086 Compare February 18, 2026 09:41
@giladravid16
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giladravid16, shay23bra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2026
@giladravid16
Copy link
Contributor

/retest

@giladravid16
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 18, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 18, 2026

@giladravid16: This pull request references ACM-29247 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.05%. Comparing base (fc83c93) to head (e6ac086).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9505      +/-   ##
==========================================
- Coverage   44.06%   44.05%   -0.01%     
==========================================
  Files         414      414              
  Lines       72172    72172              
==========================================
- Hits        31800    31795       -5     
- Misses      37496    37499       +3     
- Partials     2876     2878       +2     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ci
Copy link

openshift-ci bot commented Feb 18, 2026

@shay23bra: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 3576836 into openshift:master Feb 18, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments