OSD-17374: Fixed backplane error overwriting issue when the proxy is not available

[samanthajayasinghe]

What type of PR is this?

(bug/feature/cleanup/documentation)

What this PR does / Why we need it?

Which Jira/Github issue(s) does this PR fix?

Resolves #

Special notes for your reviewer

Pre-checks (if applicable)

• Ran unit tests locally
• Validated the changes in a cluster
• Included documentation changes with PR

[openshift-ci-robot]

@samanthajayasinghe: This pull request references OSD-17374 which is a valid jira issue.

Details

In response to this:

What type of PR is this?

(bug/feature/cleanup/documentation)

What this PR does / Why we need it?

Which Jira/Github issue(s) does this PR fix?

Resolves #

Special notes for your reviewer

Pre-checks (if applicable)

• Ran unit tests locally
• Validated the changes in a cluster
• Included documentation changes with PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[samanthajayasinghe]

/hold

[openshift-ci]

@samanthajayasinghe: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[codecov-commenter]

Codecov Report

Merging #151 (483b9ea) into main (fa5dc0f) will increase coverage by 0.34%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
+ Coverage   48.83%   49.17%   +0.34%     
==========================================
  Files          51       51              
  Lines        3264     3286      +22     
==========================================
+ Hits         1594     1616      +22     
  Misses       1397     1397              
  Partials      273      273              

Impacted Files	Coverage Δ
pkg/cli/config/config.go	57.14% <ø> (-0.27%)	⬇️

... and 4 files with indirect coverage changes

[feichashao]

/lgtm

The current logic makes sense. We see errors from login -> test the api connection e2e to determine the connection error.
The previous CheckAPIConnection assumes the user must have a proxy, which causes confusions on the localhost cases where a proxy is not required.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feichashao, samanthajayasinghe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [feichashao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[samanthajayasinghe]

/unhold