Skip to content

Updated readme with instruction to users to use an updated version of go version#170

Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
Dee-6777:leftover_kubeconfig
Aug 4, 2023
Merged

Updated readme with instruction to users to use an updated version of go version#170
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
Dee-6777:leftover_kubeconfig

Conversation

@Dee-6777
Copy link
Contributor

@Dee-6777 Dee-6777 commented Aug 4, 2023

What type of PR is this?

documentation

What this PR does / Why we need it?

It instructs the user to use an updated go version so that there won't be any kube config files left after testing

Which Jira/Github issue(s) does this PR fix?

Resolves #OSD-17636

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023

Codecov Report

Merging #170 (df5fd45) into main (fd84937) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #170   +/-   ##
=======================================
  Coverage   49.59%   49.59%           
=======================================
  Files          51       51           
  Lines        3353     3353           
=======================================
  Hits         1663     1663           
  Misses       1411     1411           
  Partials      279      279           

@Dee-6777 Dee-6777 force-pushed the leftover_kubeconfig branch from ef6436c to df5fd45 Compare August 4, 2023 06:17
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2023

@Dee-6777: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bmeng
Copy link
Contributor

bmeng commented Aug 4, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng, Dee-6777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2023
@openshift-merge-robot openshift-merge-robot merged commit bd600af into openshift:main Aug 4, 2023
@Dee-6777 Dee-6777 deleted the leftover_kubeconfig branch August 4, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants