Print cluster info by setting a flag in backplane config file.

[diakovnec]

What type of PR is this?

This is an addition to #561

This PR adds an ability to add a flag in the backplane config and the cluster info will be printed automatically every time without a need to set --cluster-into each time

Example
{ "proxy-url": ["http://squid.corp.redhat.com:3128/","http://proxy2.squi-001.prod.rdu2.dc.redhat.com:3128/"], "display-cluster-info": true }

Which Jira/Github issue(s) does this PR fix?

Resolves #

[bmeng]

/label tide/merge-method-squash

[codecov-commenter]

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.27%. Comparing base (36226a8) to head (83e6d65).
⚠️ Report is 248 commits behind head on main.

Files with missing lines	Patch %	Lines
cmd/ocm-backplane/login/login.go	0.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #578      +/-   ##
==========================================
+ Coverage   45.92%   46.27%   +0.35%     
==========================================
  Files          85       85              
  Lines        6319     6323       +4     
==========================================
+ Hits         2902     2926      +24     
+ Misses       3057     3033      -24     
- Partials      360      364       +4     

Files with missing lines	Coverage Δ
pkg/cli/config/config.go	83.07% <100.00%> (+0.13%)	⬆️
cmd/ocm-backplane/login/login.go	68.18% <0.00%> (+0.25%)	⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[bmeng]

should not print?

[bmeng]

maybe we can change the testing to positive test as well? so it would be should print when is set to true

[diakovnec]

Sorry, I am not getting what needs to be changed
It("should print a message if DisplayClusterInfo is set to true", func() {

or the test needs to be changed so it tests when

testData := config.BackplaneConfiguration{ URL: backplaneAPIURI, ProxyURL: new(string), DisplayClusterInfo: true, }

[xiaoyu74]

/retest

[bmeng]

I think we may not need to check the stdout or stderr here.
I cannot see much value of checking this in a negative test.

[diakovnec]

while looking into I've thought about diff scenario when PrintClusterInfo(clusterID) returns an error

[xiaoyu74]

As all the setting flags in the backplane configuration are currently defined as string values, but DisplayClusterInfo is defined as a bool, it would be better to emphasize that end-user should use the boolean value true instead of the string "true" in the README.md.

P.S While this might not be necessary, if you'd like to go a step further, you could implement a small utility function to handle both boolean and string values for display-cluster-info, basically, if the value is mistakenly set as a string ("true" or "false"), it is converted and interpreted as a boolean.

[bmeng]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng, diakovnec

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [bmeng]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@diakovnec: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.