Skip to content

Add small success info when creating remediation#582

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
RaphaelBut:small-fix
Jan 8, 2025
Merged

Add small success info when creating remediation#582
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
RaphaelBut:small-fix

Conversation

@RaphaelBut
Copy link
Copy Markdown
Contributor

What type of PR is this?

Adds small info that user is logged in to the cluster as the remediation ( so that one can test RBAC )

What this PR does / Why we need it?

Which Jira/Github issue(s) does this PR fix?

Resolves #

Special notes for your reviewer

Unit Test Coverage

Guidelines

  • If it's a new sub-command or new function to an existing sub-command, please cover at least 50% of the code
  • If it's a bug fix for an existing sub-command, please cover 70% of the code

Test coverage checks

  • Added unit tests
  • Created jira card to add unit test
  • This PR may not need unit tests

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

@openshift-ci openshift-ci Bot requested review from MitaliBhalla and bmeng December 18, 2024 17:32
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.34%. Comparing base (c090c68) to head (50e6f5c).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #582      +/-   ##
==========================================
+ Coverage   45.39%   46.34%   +0.95%     
==========================================
  Files          87       87              
  Lines        6759     7039     +280     
==========================================
+ Hits         3068     3262     +194     
- Misses       3311     3373      +62     
- Partials      380      404      +24     
Files with missing lines Coverage Δ
cmd/ocm-backplane/remediation/remediation.go 74.19% <100.00%> (+0.20%) ⬆️

... and 1 file with indirect coverage changes

@feichashao
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feichashao, RaphaelBut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 8, 2025

@RaphaelBut: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 52301c1 into openshift:main Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants