Speed up proxy selection code

[smarthall]

What type of PR is this?

feature

What this PR does / Why we need it?

This change speeds up the proxy selection code by performing tests on multiple proxies simultaneously.

Which Jira/Github issue(s) does this PR fix?

Resolves https://issues.redhat.com/browse/OSD-22383

Special notes for your reviewer

Unit Test Coverage

Guidelines

• If it's a new sub-command or new function to an existing sub-command, please cover at least 50% of the code
• If it's a bug fix for an existing sub-command, please cover 70% of the code

Test coverage checks

• Added unit tests
• Created jira card to add unit test
• This PR may not need unit tests

Pre-checks (if applicable)

• Ran unit tests locally
• Validated the changes in a cluster
• Included documentation changes with PR

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[smarthall]

/test all

[codecov-commenter]

Codecov Report

❌ Patch coverage is 71.69811% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.98%. Comparing base (3e3ab00) to head (8506ceb).
⚠️ Report is 421 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/cli/config/config.go	71.69%	14 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #599      +/-   ##
==========================================
+ Coverage   45.81%   46.98%   +1.16%     
==========================================
  Files          86       86              
  Lines        6742     6964     +222     
==========================================
+ Hits         3089     3272     +183     
- Misses       3274     3289      +15     
- Partials      379      403      +24     

Files with missing lines	Coverage Δ
pkg/cli/config/config.go	78.18% <71.69%> (-4.90%)	⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[smarthall]

/retest

[xiaoyu74]

Great work Daniel! The logic is clear and well meet the done criteria cases.

Tested against a prod cluster to update my proxy configuration:

cat ~/.config/backplane/config.json
{
    "proxy-url": "",
    "vpn-check-endpoint": "https://gitlab.cee.redhat.com/service/backplane-api",
    "proxy-check-endpoint": "https://api.backplane.openshift.com/healthz"
}

 ./ocm-backplane login cf9aa592-84fc-4e1c-a62e-3d48e4d4f5bd -v
WARN[0000] Your Backplane CLI is not up to date. Please run the command 'ocm backplane upgrade' to upgrade to the latest version  Current version="(devel)" Latest version=0.1.38
INFO[0001] Backplane URL retrieved via OCM environment: https://api.backplane.openshift.com
INFO[0001] No PagerDuty API Key configuration available. This will result in failure of `ocm-backplane login --pd <incident-id>` command.
INFO[0004] Target cluster                                ID=2feuradf8odo2uqdtn8t9uvr5278hchs Name=kflux-prd-rh02
INFO[0009] Backplane URL retrieved via OCM environment: https://api.backplane.openshift.com
INFO[0009] No PagerDuty API Key configuration available. This will result in failure of `ocm-backplane login --pd <incident-id>` command.
ERRO[0045] cannot connect to Backplane API URL: Head "https://api.backplane.openshift.com": context deadline exceeded (Client.Timeout exceeded while awaiting headers).

NOTE: To troubleshoot the connectivity issues, please run `ocm-backplane health-check`

Just some edge cases not covered (to mock httptest.NewServer for the testProxy) but shouldn't be a blocker to merge.

I will give LGTM but just hold for extra eyes from other colleague

/lgtm
/hold

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarthall, xiaoyu74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [xiaoyu74]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[samanthajayasinghe]

Great refactoring @smarthall ,
@xiaoyu74 seems the test covers 69.81% of new code, I feel it's good enough for now

[xiaoyu74]

/hold cancel

[openshift-ci]

@smarthall: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.