DNM: Test PR for ClusterBot, Add webhook readiness check before starting manager

[MahnoorAsghar]

Summary by CodeRabbit

• Improvements
  • Added webhook readiness validation to enhance initialization robustness

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ed1047df-5bca-4bea-862c-72f3f1ba29b0

📥 Commits

Reviewing files that changed from the base of the PR and between c5e5048 and 65d080d.

📒 Files selected for processing (1)

• main.go

---

Walkthrough

A new setupWebhookReadinessCheck() function is added to register a webhook readiness check with the controller manager. When webhooks are enabled, this check is registered during startup before webhook initialization, and the process exits if registration fails.

Changes

Cohort / File(s)	Summary
Webhook Readiness Check Setup main.go	Added setupWebhookReadinessCheck() function that registers a ReadyzCheck using the webhook server's StartedChecker(). Integrated into main startup sequence when enableWebhook is true, with error handling that exits the process on check registration failure.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

---

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Ote Binary Stdout Contract	❓ Inconclusive	Unable to verify OTE Binary Stdout Contract compliance without access to PR changes, file contents, or git diff output.	Provide the actual PR diff, main.go file contents, and any modified process-level code to verify non-JSON stdout writes.

✅ Passed checks (8 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title begins with 'DNM' (Do Not Merge), indicating this is a test PR not intended for production, and clearly describes the main change: adding a webhook readiness check before starting the manager.
Stable And Deterministic Test Names	✅ Passed	This PR only adds a webhook readiness check function to main.go and does not modify any Ginkgo test files or introduce any test names, making this check not applicable.
Test Structure And Quality	✅ Passed	This check is not applicable to the provided pull request. The PR only modifies main.go to add a setupWebhookReadinessCheck() function and does not include any Ginkgo test code changes.
Microshift Test Compatibility	✅ Passed	Pull request modifies main.go with setupWebhookReadinessCheck() function but contains no new Ginkgo e2e tests.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR adds only application code (setupWebhookReadinessCheck function) to main.go, not new Ginkgo e2e tests (It, Describe, Context, When patterns). Custom check for e2e tests does not apply.
Topology-Aware Scheduling Compatibility	✅ Passed	Pull request adds a webhook readiness check without introducing topology-aware scheduling constraints or modifying deployment manifests.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR adds webhook readiness check to main.go, which is application code not e2e tests. Custom check applies only to new Ginkgo e2e tests, which this PR does not introduce.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MahnoorAsghar
Once this PR has been reviewed and has the lgtm label, please assign honza for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[MahnoorAsghar]

/test ?

[MahnoorAsghar]

/test e2e-metal-ipi-bm

[openshift-ci]

@MahnoorAsghar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-virtualmedia	65d080d	link	true	/test e2e-metal-ipi-virtualmedia

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.