Skip to content

Updates the reviewers and approvers#196

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
TrilokGeer:owners-update
Oct 21, 2024
Merged

Updates the reviewers and approvers#196
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
TrilokGeer:owners-update

Conversation

@TrilokGeer
Copy link
Contributor

Updates the reviewers and approvers list based on recent contributors and in-active members.

Signed-off-by: Trilok Geer <tgeer@redhat.com>
@openshift-ci openshift-ci bot requested review from deads2k and swghosh August 22, 2024 07:08
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2024
@swghosh
Copy link
Member

swghosh commented Aug 22, 2024

/lgtm
/label docs-approved
/label px-approved
These changes are non-user facing.

@swghosh
Copy link
Member

swghosh commented Aug 22, 2024

@lunarwhite @xingxingxia either of you, please help with adding a qe-approved label for this to merge, thanks!

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Aug 22, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: swghosh, TrilokGeer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xingxingxia
Copy link
Contributor

@lunarwhite , would you like to be listed as reviewer? I see you actively reviewed some PRs in this repo.

@lunarwhite
Copy link
Member

@xingxingxia Thanks for nominating me. I'd be fully honored to serve as a reviewer.

@TrilokGeer @swghosh ^^ May I ask for your approval if this request is acceptable?

@swghosh
Copy link
Member

swghosh commented Oct 21, 2024

@lunarwhite can you add qe-approved label to this PR?
On a follow-up PR, I can add you as reviewer (especially for test/).

@lunarwhite
Copy link
Member

Definitely
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 21, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5f97808 and 2 for PR HEAD c9f1100 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2024

@TrilokGeer: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 4db6a67 into openshift:master Oct 21, 2024
@swghosh swghosh mentioned this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants