sort config versions for display#105
Merged
rphillips merged 2 commits intoopenshift:mainfrom Aug 4, 2023
Merged
Conversation
openshift-ci
bot
added
the
approved
rphillips
force-pushed
the
add_4.14_config_file
branch
from
74dca3a to
667f7c0
Compare
kolyshkin
reviewed
Aug 4, 2023
rphillips
force-pushed
the
add_4.14_config_file
branch
from
4e3e1fc to
896c23f
Compare
kolyshkin
reviewed
Aug 4, 2023
kolyshkin
requested changes
Aug 4, 2023
Contributor
kolyshkin
left a comment
kolyshkin
left a comment
There was a problem hiding this comment.
- I think we should not use two different packages for dealing with versions.
- Since a bunch of exceptions are the same/similar for 4.12, 4.13, 4.14, maybe we should move them to the main config? I'm thinking rpm.cri-o, rpm.podman etc.
Contributor
Author
|
hmm yeah... @kolyshkin could you PR that, and I can rebase this PR with perhaps just the sorting change. |
rphillips
force-pushed
the
add_4.14_config_file
branch
from
896c23f to
07aeac0
Compare
kolyshkin
reviewed
Aug 4, 2023
| ### Features | ||
|
|
||
| - Add 4.14 configuration. | ||
| - Add 4.14 config file |
Contributor
|
@rphillips can you squash the commits? |
rphillips
force-pushed
the
add_4.14_config_file
branch
from
07aeac0 to
31212be
Compare
kolyshkin
changed the title
kolyshkin
changed the title
Contributor
|
Sorry, it seems we clicked on "edit" for title at the same time 😆 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kolyshkin, rphillips The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.