-
Notifications
You must be signed in to change notification settings - Fork 54
Ignore rhel-coreos-10 image ErrOSNotCertified for now #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e60be9d to
6121335
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sdodson The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
4.21 and 4.22 will have RHCOS 10 images but these are not GA therefore not beholden to FIPS constraints. We will ensure that documentation when these features are made TechPreview specifically mentions that they should not be used in FIPS regulated environments.
6121335 to
65c004e
Compare
|
@sdodson: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
|
||
| # In 4.21 and 4.22 we'll have a rhel-coreos-10 and rhel-coreos-10-extensions image | ||
| # these images are devpreview / techpreview and thus not beholden to FIPS validation | ||
| # TODO: revisit this after 4.22 branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we tracking that in a ticket anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, but that's why I moved this to 4.21 config rather than top level config. I assume once branching completes we'll get 4.22 config created here or do we manage that? If so I can go ahead and do that then we can assume that the problem will pop up in our face as soon as 4.22+1 starts getting builds at which point we look at what to do.
rhmdnd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Adding @smith-xyz and @richardsonnick for awareness.
4.21 and 4.22 will have RHCOS 10 images but these are not GA therefore not beholden to FIPS constraints. We will ensure that documentation when these features are made TechPreview specifically mentions that they should not be used in FIPS regulated environments.