Skip to content

Use the same key name in oauth secret with upstream#2340

Closed
droslean wants to merge 1 commit into
openshift:masterfrom
droslean:fix-oauth-name
Closed

Use the same key name in oauth secret with upstream#2340
droslean wants to merge 1 commit into
openshift:masterfrom
droslean:fix-oauth-name

Conversation

@droslean

@droslean droslean commented Sep 4, 2021

Copy link
Copy Markdown
Member

When decoration_config.oauth_token_secret is specified, the upstream code creates a volume using a specific name for the key. In order to use it we need to generate the same key name.

This change needs:

  • Change the secret's key name in Vault
  • Regenerate the jobs

Eventually, we can change the upstream code to respect the key name value from decoration_config.oauth_token_secret.key

/cc @openshift/test-platform

Signed-off-by: Nikolaos Moraitis nmoraiti@redhat.com

Signed-off-by: Nikolaos Moraitis <nmoraiti@redhat.com>
@openshift-ci openshift-ci Bot requested a review from a team September 4, 2021 12:57
@openshift-ci

openshift-ci Bot commented Sep 4, 2021

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droslean

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2021
@droslean

droslean commented Sep 4, 2021

Copy link
Copy Markdown
Member Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 4, 2021
@droslean

droslean commented Sep 4, 2021

Copy link
Copy Markdown
Member Author

Or we can just add a new key named oauth-token to that private secret

@openshift-ci

openshift-ci Bot commented Sep 4, 2021

Copy link
Copy Markdown
Contributor

@droslean: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/breaking-changes 352a752 link /test breaking-changes

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@droslean

droslean commented Sep 4, 2021

Copy link
Copy Markdown
Member Author

@stevekuznetsov I think kubernetes/test-infra#23481 should be better approach.
/close

@openshift-ci

openshift-ci Bot commented Sep 4, 2021

Copy link
Copy Markdown
Contributor

@droslean: Closed this PR.

Details

In response to this:

@stevekuznetsov I think kubernetes/test-infra#23481 should be better approach.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot closed this Sep 4, 2021
@droslean droslean deleted the fix-oauth-name branch September 4, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant