Use the same key name in oauth secret with upstream#2340
Conversation
Signed-off-by: Nikolaos Moraitis <nmoraiti@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: droslean The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
|
Or we can just add a new key named |
|
@droslean: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@stevekuznetsov I think kubernetes/test-infra#23481 should be better approach. |
|
@droslean: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When
decoration_config.oauth_token_secretis specified, the upstream code creates a volume using a specific name for the key. In order to use it we need to generate the same key name.This change needs:
Eventually, we can change the upstream code to respect the key name value from
decoration_config.oauth_token_secret.key/cc @openshift/test-platform
Signed-off-by: Nikolaos Moraitis nmoraiti@redhat.com