Skip to content

DPTP-4183: Fix automation to include candidate release #4338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Oct 3, 2024
Merged

DPTP-4183: Fix automation to include candidate release #4338

openshift-merge-bot merged 1 commit into from
Oct 3, 2024

Conversation

@deepsm007
Copy link
Contributor

@deepsm007 deepsm007 commented Sep 19, 2024 •
edited
Loading

The config-brancher is missing few configuration eg installer configs which uses candidate stream along with integration stream. Adding support eliminates the need for manual update during branching openshift/release@4cb16b0#diff-92fb8761a3401342e7a5678fa916ff7f552fe64f9fa412105c354e691c76a736L212

/cc @openshift/test-platform

/hold

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 19, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 19, 2024 •
edited by openshift-ci bot
Loading

@deepsm007: This pull request references DPTP-4183 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

Details

In response to this:

/cc @openshift/test-platform

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from a team September 19, 2024 20:03
@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 19, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 19, 2024 •
edited by openshift-ci bot
Loading

@deepsm007: This pull request references DPTP-4183 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

Details

In response to this:

The config-brancher is missing few configuration eg installer configs which uses candidate stream along with integration stream. Adding support eliminates the need for manual update during branching openshift/release@4cb16b0#diff-92fb8761a3401342e7a5678fa916ff7f552fe64f9fa412105c354e691c76a736L212

/cc @openshift/test-platform

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 19, 2024

/test remaining-required

@smg247
Copy link
Member

smg247 commented Sep 20, 2024

have you considered adding any unit or integration tests for this change?

@deepsm007
Copy link
Contributor Author

deepsm007 commented Sep 20, 2024 

config-brancher --config-dir ./ci-operator/config --current-release=4.17 --future-release=4.18 --bump-release=4.18 --confirm
INFO[0000] Branching configuration.                      branch=master org=openshift repo=installer source-file=openshift-installer-master.yaml variant=

git diff ci-operator/config/openshift/installer/openshift-installer-master.yaml 
diff --git a/ci-operator/config/openshift/installer/openshift-installer-master.yaml b/ci-operator/config/openshift/installer/openshift-installer-master.yaml
index e4cd399c142..8d796b68f21 100644
--- a/ci-operator/config/openshift/installer/openshift-installer-master.yaml
+++ b/ci-operator/config/openshift/installer/openshift-installer-master.yaml
@@ -251,13 +251,13 @@ releases:
       architecture: multi
       product: ocp
       stream: nightly
-      version: "4.17"
+      version: "4.18"
   ppc64le-latest:
     candidate:
       architecture: ppc64le
       product: ocp
       stream: nightly
-      version: "4.17"
+      version: "4.18"
 resources:
   '*':
     requests:

@deepsm007
Copy link
Contributor Author

deepsm007 commented Oct 2, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 2, 2024
@deepsm007
Copy link
Contributor Author

deepsm007 commented Oct 2, 2024

/test e2e

@smg247
Copy link
Member

smg247 commented Oct 2, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007, smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepsm007
Copy link
Contributor Author

deepsm007 commented Oct 2, 2024

/test e2e

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 2, 2024

/retest-required

Remaining retests: 0 against base HEAD 716f066 and 2 for PR HEAD 8ee97e7 in total

@deepsm007
Copy link
Contributor Author

deepsm007 commented Oct 2, 2024

/test images

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 2, 2024

/retest-required

Remaining retests: 0 against base HEAD 716f066 and 2 for PR HEAD 8ee97e7 in total

6 similar comments
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 2, 2024

/retest-required

Remaining retests: 0 against base HEAD 716f066 and 2 for PR HEAD 8ee97e7 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 3, 2024

/retest-required

Remaining retests: 0 against base HEAD 716f066 and 2 for PR HEAD 8ee97e7 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 3, 2024

/retest-required

Remaining retests: 0 against base HEAD 716f066 and 2 for PR HEAD 8ee97e7 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 3, 2024

/retest-required

Remaining retests: 0 against base HEAD 716f066 and 2 for PR HEAD 8ee97e7 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 3, 2024

/retest-required

Remaining retests: 0 against base HEAD 716f066 and 2 for PR HEAD 8ee97e7 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 3, 2024

/retest-required

Remaining retests: 0 against base HEAD 716f066 and 2 for PR HEAD 8ee97e7 in total

@danilo-gemoli
Copy link
Contributor

danilo-gemoli commented Oct 3, 2024

/retest-required

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 3, 2024

/retest-required

Remaining retests: 0 against base HEAD 716f066 and 2 for PR HEAD 8ee97e7 in total

3 similar comments
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 3, 2024

/retest-required

Remaining retests: 0 against base HEAD 716f066 and 2 for PR HEAD 8ee97e7 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 3, 2024

/retest-required

Remaining retests: 0 against base HEAD 716f066 and 2 for PR HEAD 8ee97e7 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 3, 2024

/retest-required

Remaining retests: 0 against base HEAD 716f066 and 2 for PR HEAD 8ee97e7 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 3, 2024

/retest-required

Remaining retests: 0 against base HEAD bc1d333 and 2 for PR HEAD 8ee97e7 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2024

@deepsm007: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 8ee97e7 link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit f76c2c6 into openshift:master Oct 3, 2024
@deepsm007 deepsm007 deleted the configbrancher branch October 28, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@smg247 smg247

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@deepsm007 @openshift-ci-robot @smg247 @danilo-gemoli