Revert "prowgen: use preset for registry pull credentials volume"#5019
Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom Mar 17, 2026
Conversation
Contributor
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: petr-muller The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (202)
Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to WalkthroughThis change removes the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
|
There was a problem hiding this comment.
Pull request overview
This PR removes reliance on the presets.ci.openshift.io/registry-pull Prow preset by explicitly mounting the cluster pull-secret into generated ci-operator pods, and updates the related integration/fixture outputs accordingly.
Changes:
- Add an explicit
/etc/pull-secretvolume + mount (fromregistry-pull-credentials) to the prowgen default PodSpec, and remove the registry-pull preset label/default. - Remove the now-unused
PresetRegistryPullLabelconstant and update generated job YAML fixtures to include the pull-secret volume instead of the preset label. - Adjust integration test runner argument passing (currently introduces an issue; see PR comments).
Reviewed changes
Copilot reviewed 202 out of 202 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/integration/repo-init/expected/ci-operator/jobs/org/third/org-third-nonstandard-presubmits.yaml | Update expected jobs: remove registry-pull preset label; add pull-secret volume/mount |
| test/integration/repo-init/expected/ci-operator/jobs/org/repo/org-repo-main-presubmits.yaml | Update expected jobs: remove registry-pull preset label; add pull-secret volume/mount |
| test/integration/repo-init/expected/ci-operator/jobs/org/other/org-other-nonstandard-presubmits.yaml | Update expected jobs: remove registry-pull preset label; add pull-secret volume/mount |
| test/integration/repo-init/expected/ci-operator/jobs/openshift/origin/openshift-origin-main-presubmits.yaml | Update expected jobs: remove registry-pull preset label; add pull-secret volume/mount |
| test/integration/repo-init/expected/ci-operator/jobs/openshift/origin/openshift-origin-main-postsubmits.yaml | Update expected jobs: remove registry-pull preset label; add pull-secret volume/mount |
| test/integration/repo-init/expected/ci-operator/jobs/openshift/ci-tools/openshift-ci-tools-master-presubmits.yaml | Update expected jobs: remove registry-pull preset label; add pull-secret volume/mount |
| test/integration/repo-init/expected/ci-operator/jobs/openshift/ci-tools/openshift-ci-tools-master-postsubmits.yaml | Update expected jobs: remove registry-pull preset label; add pull-secret volume/mount |
| test/integration/pj-rehearse/master/ci-operator/jobs/uses/observer/uses-observer-master-presubmits.yaml | Update rehearsal fixtures: remove preset label; add pull-secret volume/mount |
| test/integration/pj-rehearse/master/ci-operator/jobs/super/trooper/super-trooper-master-presubmits.yaml | Update rehearsal fixtures: remove preset label; add pull-secret volume/mount |
| test/integration/pj-rehearse/master/ci-operator/jobs/super/trooper/super-trooper-master-periodics.yaml | Update rehearsal fixtures: remove preset label; add pull-secret volume/mount |
| test/integration/pj-rehearse/master/ci-operator/jobs/super/duper/super-duper-master-presubmits.yaml | Update rehearsal fixtures: remove preset label; add pull-secret volume/mount |
| test/integration/pj-rehearse/master/ci-operator/jobs/super/duper/super-duper-cluster-profile-presubmits.yaml | Update rehearsal fixtures: remove preset label; add pull-secret volume/mount |
| test/integration/pj-rehearse/master/ci-operator/jobs/super/duper/super-duper-ciop-cfg-change-presubmits.yaml | Update rehearsal fixtures: remove preset label; add pull-secret volume/mount |
| test/integration/pj-rehearse/candidate/ci-operator/jobs/uses/observer/uses-observer-master-presubmits.yaml | Update rehearsal fixtures: remove preset label; add pull-secret volume/mount |
| test/integration/pj-rehearse/candidate/ci-operator/jobs/super/trooper/super-trooper-master-presubmits.yaml | Update rehearsal fixtures: remove preset label; add pull-secret volume/mount |
| test/integration/pj-rehearse/candidate/ci-operator/jobs/super/trooper/super-trooper-master-periodics.yaml | Update rehearsal fixtures: remove preset label; add pull-secret volume/mount |
| test/integration/pj-rehearse/candidate/ci-operator/jobs/super/duper/super-duper-master-presubmits.yaml | Update rehearsal fixtures: remove preset label; add pull-secret volume/mount |
| test/integration/pj-rehearse/candidate/ci-operator/jobs/super/duper/super-duper-cluster-profile-presubmits.yaml | Update rehearsal fixtures: remove preset label; add pull-secret volume/mount |
| test/integration/pj-rehearse/candidate/ci-operator/jobs/super/duper/super-duper-ciop-cfg-change-presubmits.yaml | Update rehearsal fixtures: remove preset label; add pull-secret volume/mount |
| test/integration/ci-operator-prowgen/output/jobs/super/duper/super-duper-release-4.19-periodics.yaml | Update generated prowgen output fixtures: add pull-secret volume/mount |
| test/integration/ci-operator-prowgen/output/jobs/super/duper/super-duper-release-3.11-presubmits.yaml | Update generated prowgen output fixtures: add pull-secret volume/mount |
| test/integration/ci-operator-prowgen/output/jobs/super/duper/super-duper-release-3.11-postsubmits.yaml | Update generated prowgen output fixtures: add pull-secret volume/mount |
| test/integration/ci-operator-prowgen/output/jobs/super/duper/super-duper-master-removed-promotion-presubmits.yaml | Update generated prowgen output fixtures: add pull-secret volume/mount |
| test/integration/ci-operator-prowgen/output/jobs/super/duper/super-duper-master-postsubmits.yaml | Update generated prowgen output fixtures: add pull-secret volume/mount |
| test/integration/ci-operator-prowgen/output/jobs/super/duper/super-duper-master-periodics.yaml | Update generated prowgen output fixtures: add pull-secret volume/mount |
| test/integration/ci-operator-prowgen/output/jobs/super/duper/super-duper-job-release-periodics.yaml | Update generated prowgen output fixtures: add pull-secret volume/mount |
| test/integration/ci-operator-prowgen/output/jobs/subdir/repo/subdir-repo-master-presubmits.yaml | Update generated prowgen output fixtures: add pull-secret volume/mount |
| test/integration/ci-operator-prowgen/output/jobs/slack-report/duper/slack-report-duper-master-presubmits.yaml | Update generated prowgen output fixtures: add pull-secret volume/mount |
| test/integration/ci-operator-prowgen/output/jobs/slack-report/duper/slack-report-duper-master-postsubmits.yaml | Update generated prowgen output fixtures: add pull-secret volume/mount |
| test/integration/ci-operator-prowgen/output/jobs/slack-report/duper/slack-report-duper-master-periodics.yaml | Update generated prowgen output fixtures: add pull-secret volume/mount |
| test/integration/ci-operator-prowgen/output/jobs/sharded/repo/sharded-repo-main-presubmits.yaml | Update generated prowgen output fixtures: add pull-secret volume/mount |
| test/integration/ci-operator-prowgen/output/jobs/private/duper/private-duper-master-presubmits.yaml | Update generated prowgen output fixtures: add pull-secret volume/mount |
| test/integration/ci-operator-prowgen/output/jobs/private/duper/private-duper-master-postsubmits.yaml | Update generated prowgen output fixtures: add pull-secret volume/mount |
| test/integration/ci-operator-prowgen/output/jobs/private/duper/private-duper-master-periodics.yaml | Update generated prowgen output fixtures: add pull-secret volume/mount |
| test/integration/ci-operator-prowgen/output/jobs/private-org/super/private-org-super-master-presubmits.yaml | Update generated prowgen output fixtures: add pull-secret volume/mount |
| test/integration/ci-operator-prowgen/output/jobs/private-org/duper/private-org-duper-master-presubmits.yaml | Update generated prowgen output fixtures: add pull-secret volume/mount |
| test/integration/ci-operator-prowgen/output/jobs/norehearsals/stuper/norehearsals-stuper-master-presubmits.yaml | Update generated prowgen output fixtures: add pull-secret volume/mount |
| test/integration/ci-operator-prowgen/output/jobs/norehearsals/stuper/norehearsals-stuper-master-postsubmits.yaml | Update generated prowgen output fixtures: add pull-secret volume/mount |
| test/integration/ci-operator-prowgen/output/jobs/norehearsals/duper/norehearsals-duper-master-presubmits.yaml | Update generated prowgen output fixtures: add pull-secret volume/mount |
| test/integration/ci-operator-prowgen/output/jobs/norehearsals/duper/norehearsals-duper-master-postsubmits.yaml | Update generated prowgen output fixtures: add pull-secret volume/mount |
| test/integration/ci-operator-prowgen/output/jobs/legacy/random-file/legacy-random-file-master-periodics.yaml | Update legacy output fixture: add pull-secret volume/mount |
| test/integration/ci-operator-prowgen/output/jobs/legacy/branches-separate-files/legacy-branches-separate-files-master-presubmits.yaml | Update legacy output fixture: add pull-secret volume/mount |
| test/integration/ci-operator-prowgen/output/jobs/legacy/branches-separate-files/legacy-branches-separate-files-branch-presubmits.yaml | Update legacy output fixture: add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestTemplate_template_with_different_command.yaml | Update prowgen fixture: add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestTemplate_template_with_command.yaml | Update prowgen fixture: add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestTemplate_template_with_a_custom_test_image.yaml | Update prowgen fixture: add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestTemplate_different_template_with_command.yaml | Update prowgen fixture: add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestTargets_single_target.yaml | Update prowgen fixture: add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestTargets_multiple_targets.yaml | Update prowgen fixture: add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestTargetAdditionalSuffix_target_additional_suffix_is_added.yaml | Update prowgen fixture: add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestSecrets_one_secret.yaml | Update prowgen fixture: add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestSecrets_multiple_secrets.yaml | Update prowgen fixture: add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestSecrets_empty_list_is_a_nop.yaml | Update prowgen fixture: add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestReleaseRpms_envvar_additional_envvar_generated_for_template.yaml | Update prowgen fixture: add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestReleaseLatest_add_release_latest.yaml | Update prowgen fixture: add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestReleaseInitial_add_release_initial.yaml | Update prowgen fixture: add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestProwJobBaseBuilder_private_job_without_cloning__including_podspec.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestProwJobBaseBuilder_private_job_with_cloning__including_podspec.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestProwJobBaseBuilder_job_with_test_binary_build_in_of_openshift_release_main__does_not_have_no_builds__label.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestProwJobBaseBuilder_job_with_not_a_latest_release_that_is_a_candidate__does_not_have_job_release__label.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestProwJobBaseBuilder_job_with_no_builds_outside_of_openshift_release_main__does_not_have_no_builds__label.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestProwJobBaseBuilder_job_with_no_builds_in_openshift_release_main__does_have_no_builds__label.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestProwJobBaseBuilder_job_with_latest_release_that_is_not_a_candidate__does_not_have_job_release__label.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestProwJobBaseBuilder_job_with_latest_release_that_is_a_candidate__has_job_release__label.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestProwJobBaseBuilder_job_with_image_builds_in_of_openshift_release_main__does_not_have_no_builds__label.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestProwJobBaseBuilder_job_with_configured_prefix.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestProwJobBaseBuilder_job_with_binary_build_in_openshift_release_main__does_not_have_no_builds__label.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestProwJobBaseBuilder_job_with_a_variant.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestProwJobBaseBuilder_job_with_a_variant__including_podspec.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestProwJobBaseBuilder_job_with_a_buildroot_in_of_openshift_release_main__does_not_have_no_builds__label.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestProwJobBaseBuilder_default_job_without_further_configuration.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestProwJobBaseBuilder_default_job_without_further_configuration__including_podspec.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestPromotion_secret_and_parameters_are_added.yaml | Update prowgen fixture: add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_simple_with_slack_reporter_config.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_simple_test_with_CSI_enabled.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_simple_container_based_test.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_simple_container_based_test_with_timeout.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_simple_container_based_test_with_timeout_and_no_decoration.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_simple_container_based_test_with_secrets.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_simple_container_based_test_with_secret.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_simple_container_based_test_with_cluster.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_OpenshiftInstallerUPIClusterTestConfiguration.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_OpenshiftInstallerCustomTestImageClusterTestConfiguration.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_OpenshiftInstallerClusterTestConfiguration.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_OpenshiftAnsibleCustomClusterTestConfiguration.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_OpenshiftAnsibleClusterTestConfiguration.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_multi_stage_test.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_multi_stage_test_with_releases.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_multi_stage_test_with_CSI_enabled.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_multi_stage_test_with_cluster_profile.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_multi_stage_test_with_claim.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_literal_multi_stage_test.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_job_excluded_by_patterns_should_not_have_slack_reporter_config.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestNewCiOperatorPodSpecGenerator_parameter_is_added_for_variant.yaml | Update prowgen fixture: add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestNewCiOperatorPodSpecGenerator_no_parameter_is_added_when_variant_is_empty.yaml | Update prowgen fixture: add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestNewCiOperatorPodSpecGenerator_defaults_repo.yaml | Update prowgen fixture: add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestMiscellaneous_WithLabel.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestMiscellaneous_TestName.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestMiscellaneous_Rehearsable.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestMiscellaneous_PathAlias.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestMiscellaneous_Cluster.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestLeaseClient_secret_is_added.yaml | Update prowgen fixture: add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestInjectTestFrom_inject_coordinates_without_variant.yaml | Update prowgen fixture: add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestInjectTestFrom_inject_coordinates_with_variant.yaml | Update prowgen fixture: add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestGSMConfig_add_gsm_config_volume_and_mount.yaml | Update prowgen fixture: add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestGitHubToken_podspec_for_private_repo_without_reusing_Prow_s_volume_with_credentials.yaml | Update prowgen fixture: add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestGitHubToken_podspec_for_private_repo__reusing_Prow_s_volume_with_credentials.yaml | Update prowgen fixture: add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestGeneratePresubmitForTest_rehearsal_disabled.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGeneratePresubmitForTest_presubmit_with_skip_if_only_changed.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGeneratePresubmitForTest_presubmit_with_run_if_changed.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGeneratePresubmitForTest_presubmit_with_always_run_false.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGeneratePresubmitForTest_presubmit_with_always_run_false_and_pipeline_skip_if_only_changed.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGeneratePresubmitForTest_presubmit_with_always_run_false_and_pipeline_run_if_changed.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGeneratePresubmitForTest_presubmit_with_always_run_but_run_if_changed_set.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGeneratePresubmitForTest_presubmit_with_always_run_but_pipeline_skip_if_only_changed_set.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGeneratePresubmitForTest_presubmit_with_always_run_but_pipeline_run_if_changed_set.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGeneratePresubmitForTest_presubmit_with_always_run_but_optional_true.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGeneratePresubmitForTest_presubmit_for_standard_test.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGeneratePresubmitForTest_presubmit_for_a_test_in_a_variant_config.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGeneratePresubmitForTest_optional_presubmit.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGeneratePresubmitForTest_capabilities_added.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGeneratePostSubmitForTest_Uppercase_org__repo_and_branch.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGeneratePostSubmitForTest_postsubmit_with_skip_if_only_changed.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGeneratePostSubmitForTest_postsubmit_with_run_if_changed.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGeneratePostSubmitForTest_postsubmit_with_capabilities.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGeneratePostSubmitForTest_Lowercase_org_repo_and_branch.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGeneratePeriodicForTest_periodic_with_disabled_rehearsal.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGeneratePeriodicForTest_periodic_with_capabilities.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGeneratePeriodicForTest_periodic_using_minimum_interval.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGeneratePeriodicForTest_periodic_using_interval.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGeneratePeriodicForTest_periodic_for_standard_test.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGeneratePeriodicForTest_periodic_for_a_test_with_retry.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGeneratePeriodicForTest_periodic_for_a_test_in_a_variant_config.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobs_two_tests_and_nonempty_Images_so_two_test_presubmits_and_images_pre_postsubmits_are_generated_.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobs_two_tests_and_empty_Images_with_one_test_configured_as_a_postsubmit.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobs_two_tests_and_empty_Images_so_only_two_test_presubmits_are_generated.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobs_template_test.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobs_sharded_presubmit.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobs_promotion_postsubmit_and_periodic_.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobs_Promotion_configuration_causes_promote_job.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobs_Promotion_configuration_causes_promote_job_with_unique_targets.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobs_periodic_with_presubmit.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobs_periodic_with_capabilities.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobs_periodic_presubmit_with_capabilities.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobs_operator_section_without_index_creates_ci_index_my_bundle_presubmit_job.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobs_operator_section_creates_ci_index_presubmit_job.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobs_operator_section_creates_ci_index_my_bundle_presubmit_job.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobs_operator_section_creates_bundle_with_capabilities.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobs_no_Promotion_configuration_has_no_branch_job.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobs_multiarch_test_job.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobs_multiarch_postsubmit_images.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobs_kvm_label.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobs_images_job_is_configured_for_slack_reporting.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobs_disabled_rehearsals_at_repo_level.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobs_disabled_rehearsals_at_job_level.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobs_cluster_label_for_presubmit.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobs_cluster_label_for_postsubmit.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobs_cluster_label_for_periodic.yaml | Update prowgen fixture: remove preset label; add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobBase_rehearsable.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobBase_path_alias.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobBase_no_special_options.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobBase_hidden_job_for_private_repos.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobBase_expose_option_set_but_not_private.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobBase_expose_job_for_private_repos_with_public_results.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestGenerateJobBase_config_variant.yaml | Update prowgen fixture: remove preset label |
| pkg/prowgen/testdata/zz_fixture_TestCustomHashInput_custom_hash_inputs_are_added.yaml | Update prowgen fixture: add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestCustomHashInput_custom_hash_input_is_added.yaml | Update prowgen fixture: add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestClaims_secret_is_added.yaml | Update prowgen fixture: add pull-secret volume/mount |
| pkg/prowgen/testdata/zz_fixture_TestCIPullSecret_secret_is_added.yaml | Update prowgen fixture: add pull-secret volume/mount |
| pkg/prowgen/podspec.go | Implement explicit pull-secret volume/mount; update env var constant reference |
| pkg/prowgen/jobbase.go | Remove default registry-pull preset label from generated JobBase |
| pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_override_tag.yaml | Update controller test fixture: add pull-secret volume/mount |
| pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_override_initial_and_base_payload_pullspecs.yaml | Update controller test fixture: add pull-secret volume/mount |
| pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_multiple_PRs_from_the_same_repository.yaml | Update controller test fixture: add pull-secret volume/mount |
| pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_multiple_PRs_from_different_repositories.yaml | Update controller test fixture: add pull-secret volume/mount |
| pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_multiple_case__one_of_the_prowjobs_already_exists.yaml | Update controller test fixture: add pull-secret volume/mount |
| pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case.yaml | Update controller test fixture: add pull-secret volume/mount |
| pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case_without_PR__testing_specified_base.yaml | Update controller test fixture: add pull-secret volume/mount |
| pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case_with_variant.yaml | Update controller test fixture: add pull-secret volume/mount |
| pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case_with_sharded_job.yaml | Update controller test fixture: add pull-secret volume/mount |
| pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_case_with_no_PRs_included__testing_determined_base.yaml | Update controller test fixture: add pull-secret volume/mount |
| pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_aggregated_case.yaml | Update controller test fixture: add pull-secret volume/mount |
| pkg/controller/ephemeralcluster/testdata/zz_fixture_pj_TestCreateProwJob_Inject_missing_PR_metadata.yaml | Update controller test fixture: remove preset label; add pull-secret volume/mount |
| pkg/controller/ephemeralcluster/testdata/zz_fixture_pj_TestCreateProwJob_Hive_cluster_request_creates_a_ProwJob.yaml | Update controller test fixture: remove preset label; add pull-secret volume/mount |
| pkg/controller/ephemeralcluster/testdata/zz_fixture_pj_TestCreateProwJob_An_EphemeralCluster_request_creates_a_ProwJob.yaml | Update controller test fixture: remove preset label; add pull-secret volume/mount |
| pkg/api/constant.go | Remove PresetRegistryPullLabel constant (no longer used) |
| hack/test-integration.sh | Integration runner argument handling adjustment |
| cmd/multi-pr-prow-plugin/testdata/zz_fixture_TestHandle_trigger_multiple_multi_pr_job_runs_with_diverse_additional_PRs.yaml | Update plugin fixture: add pull-secret volume/mount |
| cmd/multi-pr-prow-plugin/testdata/zz_fixture_TestHandle_trigger_a_single_multi_pr_job_run_with_additional_PR_from_the_same_repo.yaml | Update plugin fixture: add pull-secret volume/mount |
| cmd/multi-pr-prow-plugin/testdata/zz_fixture_TestHandle_trigger_a_single_multi_pr_job_run_with_additional_PR_from_a_different_repo.yaml | Update plugin fixture: add pull-secret volume/mount |
| cmd/multi-pr-prow-plugin/testdata/zz_fixture_TestGenerateProwJob_multiple_additional_PRs.yaml | Update plugin fixture: add pull-secret volume/mount |
| cmd/multi-pr-prow-plugin/testdata/zz_fixture_TestGenerateProwJob_additional_PR_from_the_same_repo.yaml | Update plugin fixture: add pull-secret volume/mount |
| cmd/ci-operator-prowgen/testdata/zz_fixture_presubmit_TestFromCIOperatorConfigToProwYaml_Using_a_variant_config__one_test_and_images__one_existing_job._Expect_one_presubmit__pre_post_submit_images_jobs._Existing_job_should_not_be_changed..yaml | Update prowgen cmd fixture: remove preset label; add pull-secret volume/mount |
| cmd/ci-operator-prowgen/testdata/zz_fixture_presubmit_TestFromCIOperatorConfigToProwYaml_one_test_and_images__no_previous_jobs._Expect_test_presubmit__pre_post_submit_images_jobs.yaml | Update prowgen cmd fixture: remove preset label; add pull-secret volume/mount |
| cmd/ci-operator-prowgen/testdata/zz_fixture_presubmit_TestFromCIOperatorConfigToProwYaml_Input_is_YAML_and_it_is_correctly_processed.yaml | Update prowgen cmd fixture: remove preset label; add pull-secret volume/mount |
| cmd/ci-operator-prowgen/testdata/zz_fixture_presubmit_TestFromCIOperatorConfigToProwYaml_Custom_test_timeout.yaml | Update prowgen cmd fixture: remove preset label; add pull-secret volume/mount |
| cmd/ci-operator-prowgen/testdata/zz_fixture_postsubmit_TestFromCIOperatorConfigToProwYaml_Using_a_variant_config__one_test_and_images__one_existing_job._Expect_one_presubmit__pre_post_submit_images_jobs._Existing_job_should_not_be_changed..yaml | Update prowgen cmd fixture: remove preset label; add pull-secret volume/mount |
| cmd/ci-operator-prowgen/testdata/zz_fixture_postsubmit_TestFromCIOperatorConfigToProwYaml_one_test_and_images__no_previous_jobs._Expect_test_presubmit__pre_post_submit_images_jobs.yaml | Update prowgen cmd fixture: remove preset label; add pull-secret volume/mount |
| cmd/ci-operator-prowgen/testdata/zz_fixture_postsubmit_TestFromCIOperatorConfigToProwYaml_Input_is_YAML_and_it_is_correctly_processed.yaml | Update prowgen cmd fixture: remove preset label; add pull-secret volume/mount |
| cmd/ci-operator-prowgen/testdata/zz_fixture_postsubmit_TestFromCIOperatorConfigToProwYaml_Custom_test_timeout.yaml | Update prowgen cmd fixture: remove preset label; add pull-secret volume/mount |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+14
to
16
| "github.com/openshift/ci-tools/pkg/api" | ||
| cioperatorapi "github.com/openshift/ci-tools/pkg/api" | ||
| "github.com/openshift/ci-tools/pkg/steps/utils" |
| fi | ||
| } | ||
| tests=( $(find_tests "${1:-.*}") ) | ||
| tests=( $(find_tests ${1:-.*}) ) |
petr-muller
added a commit
to petr-muller/ci-tools
that referenced
this pull request
Mar 19, 2026
Second attempt to do openshift#4994 after we had to revert openshift#5019 Move the pull-secret volume and volumeMount from the hardcoded defaultPodSpec to a Prow preset. This is a proof of concept for using compositional Prow presets to deduplicate the ~28 lines of boilerplate volumes/mounts that are inlined into every one of the 126K+ generated Prowjob definitions. The preset is defined in openshift/release and matched via a new label added to all prowgen-generated jobs. The --image-import-pull-secret arg remains inline since presets cannot inject container args. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
petr-muller
added a commit
to petr-muller/ci-tools
that referenced
this pull request
Mar 19, 2026
Second attempt to do openshift#4994 after we had to revert openshift#5019 Move the pull-secret volume and volumeMount from the hardcoded defaultPodSpec to a Prow preset. This is a proof of concept for using compositional Prow presets to deduplicate the ~28 lines of boilerplate volumes/mounts that are inlined into every one of the 126K+ generated Prowjob definitions. The preset is defined in openshift/release and matched via a new label added to all prowgen-generated jobs. The --image-import-pull-secret arg remains inline since presets cannot inject container args. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
petr-muller
added a commit
to petr-muller/ci-tools
that referenced
this pull request
Apr 19, 2026
Third attempt to do openshift#4994 after we had to revert openshift#5019 Move the pull-secret volume and volumeMount from the hardcoded defaultPodSpec to a Prow preset. This is a proof of concept for using compositional Prow presets to deduplicate the ~28 lines of boilerplate volumes/mounts that are inlined into every one of the 126K+ generated Prowjob definitions. The preset is defined in openshift/release and matched via a new label added to all prowgen-generated jobs. The --image-import-pull-secret arg remains inline since presets cannot inject container args. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
petr-muller
added a commit
to petr-muller/ci-tools
that referenced
this pull request
Apr 19, 2026
Third attempt to do openshift#4994 after we had to revert openshift#5019 Move the pull-secret volume and volumeMount from the hardcoded defaultPodSpec to a Prow preset. This is a proof of concept for using compositional Prow presets to deduplicate the ~28 lines of boilerplate volumes/mounts that are inlined into every one of the 126K+ generated Prowjob definitions. The preset is defined in openshift/release and matched via a new label added to all prowgen-generated jobs. The --image-import-pull-secret arg remains inline since presets cannot inject container args. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
petr-muller
added a commit
to petr-muller/ci-tools
that referenced
this pull request
Apr 23, 2026
Third attempt to do openshift#4994 after we had to revert openshift#5019 Move the pull-secret volume and volumeMount from the hardcoded defaultPodSpec to a Prow preset. This is a proof of concept for using compositional Prow presets to deduplicate the ~28 lines of boilerplate volumes/mounts that are inlined into every one of the 126K+ generated Prowjob definitions. The preset is defined in openshift/release and matched via a new label added to all prowgen-generated jobs. The --image-import-pull-secret arg remains inline since presets cannot inject container args. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
petr-muller
added a commit
to petr-muller/ci-tools
that referenced
this pull request
Apr 27, 2026
Third attempt to do openshift#4994 after we had to revert openshift#5019 Move the pull-secret volume and volumeMount from the hardcoded defaultPodSpec to a Prow preset. This is a proof of concept for using compositional Prow presets to deduplicate the ~28 lines of boilerplate volumes/mounts that are inlined into every one of the 126K+ generated Prowjob definitions. The preset is defined in openshift/release and matched via a new label added to all prowgen-generated jobs. The --image-import-pull-secret arg remains inline since presets cannot inject container args. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
petr-muller
added a commit
to petr-muller/ci-tools
that referenced
this pull request
May 1, 2026
Third attempt to do openshift#4994 after we had to revert openshift#5019 Move the pull-secret volume and volumeMount from the hardcoded defaultPodSpec to a Prow preset. This is a proof of concept for using compositional Prow presets to deduplicate the ~28 lines of boilerplate volumes/mounts that are inlined into every one of the 126K+ generated Prowjob definitions. The preset is defined in openshift/release and matched via a new label added to all prowgen-generated jobs. The --image-import-pull-secret arg remains inline since presets cannot inject container args. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
petr-muller
added a commit
to petr-muller/ci-tools
that referenced
this pull request
May 1, 2026
Third attempt to do openshift#4994 after we had to revert openshift#5019 Move the pull-secret volume and volumeMount from the hardcoded defaultPodSpec to a Prow preset. This is a proof of concept for using compositional Prow presets to deduplicate the ~28 lines of boilerplate volumes/mounts that are inlined into every one of the 126K+ generated Prowjob definitions. The preset is defined in openshift/release and matched via a new label added to all prowgen-generated jobs. The --image-import-pull-secret arg remains inline since presets cannot inject container args. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4994
For some reason rehearsals stopped working on openshift/release#76266 despite working previously