Skip to content

Conversation

@PratikMahajan
Copy link
Contributor

No description provided.

@PratikMahajan PratikMahajan changed the title add support for cluster-wide proxy [wip] add support for cluster-wide proxy Jun 10, 2022
@PratikMahajan PratikMahajan changed the title [wip] add support for cluster-wide proxy [Bug 2094562] add support for cluster-wide proxy Jun 10, 2022
@PratikMahajan PratikMahajan changed the title [Bug 2094562] add support for cluster-wide proxy Bug 2094562: add support for cluster-wide proxy Jun 10, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2022

@PratikMahajan: This pull request references Bugzilla bug 2094562, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @shellyyang1989

Details

In response to this:

Bug 2094562: add support for cluster-wide proxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from shellyyang1989 June 10, 2022 19:27
@LalatenduMohanty
Copy link
Member

I do not see code to handle the CA cert for some https proxy setting, do we plan to handle that later ?

transfer the proxy env variables to the cincinnati operand
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 13, 2022

@PratikMahajan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@PratikMahajan
Copy link
Contributor Author

PratikMahajan commented Jun 13, 2022

I do not see code to handle the CA cert for some https proxy setting, do we plan to handle that later ?

Yes, we'll be handling CA certs for Https proxy settings later.

Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, PratikMahajan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2022
@openshift-ci openshift-ci bot merged commit 2480eb2 into openshift:master Jun 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 13, 2022

@PratikMahajan: All pull requests linked via external trackers have merged:

Bugzilla bug 2094562 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2094562: add support for cluster-wide proxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants