OTA-1838: chore(Dockerfile): Use ubi-minimal for base images by DavidHurta · Pull Request #1067 · openshift/cincinnati

DavidHurta · 2026-05-15T16:06:01Z

We do not need to update the base image in the build stage, but I do not see a reason why we should not use the minimal for all stages while we are at it.

The container image built using the Dockerfile is now being exercised in relevant CI presubmit jobs (openshift/release#79424).

openshift-ci · 2026-05-15T16:06:06Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

coderabbitai · 2026-05-15T16:06:09Z

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

dist/Dockerfile.deploy/Dockerfile is excluded by !**/dist/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 574ebd21-4910-45eb-a3cd-31d726a6469d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

DavidHurta · 2026-05-15T16:06:09Z

/test all

DavidHurta · 2026-05-15T16:18:23Z

/hold

The CI only checks whether the image can be built using the Dockerfile. It does not run testing on the built image.

DavidHurta · 2026-05-18T18:05:32Z

/unhold

openshift/release#79424 merged.

DavidHurta · 2026-05-18T18:05:42Z

/test all

Use microdnf because dnf is not available in the minimal image.

openshift-ci-robot · 2026-05-18T22:37:58Z

@DavidHurta: This pull request references OTA-1838 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

DavidHurta · 2026-05-18T22:38:26Z

@coderabbitai help

coderabbitai · 2026-05-18T22:38:31Z

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

CodeRabbit commands

These commands are invoked using PR/Issue comments.

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai rate limit to show your current review rate limit status.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai evaluate custom pre-merge check --instructions <custom-checks-instructions> --name <custom-checks-title> [--mode <error|warning>] to validate the custom pre-merge checks instructions. Defaults to error when --mode is omitted.
@coderabbitai ignore pre-merge checks to override pre-merge checks and get an approval on PR.
@coderabbitai run pre-merge checks to run pre-merge checks on the pull request.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve merge conflict to automatically resolve merge conflicts.
@coderabbitai autofix to automatically fix issues identified in unresolved review comments.
@coderabbitai resolve to resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai generate configuration to create a PR that adds the current resolved configuration as .coderabbit.yaml (or show it if already present).
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, support, documentation and community

Visit our status page to check the current availability of CodeRabbit.
Create a ticket on our support page for assistance with any issues or questions.
Visit our documentation site for detailed information on how to use CodeRabbit.
Join our Discord community to connect with other users and get help from the community.
Follow us on X/Twitter for updates and announcements.

DavidHurta · 2026-05-18T22:38:46Z

@coderabbitai resume

coderabbitai · 2026-05-18T22:38:51Z

✅ Actions performed

Reviews resumed.

DavidHurta · 2026-05-18T22:39:16Z

@coderabbitai summary

coderabbitai · 2026-05-18T22:39:21Z

✅ Actions performed

Summary regeneration triggered.

openshift-ci · 2026-05-18T23:20:16Z

@DavidHurta: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

DavidHurta · 2026-05-18T23:23:49Z

/label acknowledge-critical-fixes-only

Very important maintenance.

wking

/lgtm

wking

/lgtm

openshift-ci · 2026-05-18T23:40:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidHurta, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [DavidHurta,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift#1067 uses the ubi-minimal images. > We do not need to update the base image in the build stage, but I do not see a reason why we should not use the minimal for all stages while we are at it. This pull gives a reason: It saves the dependency installation in each CI build. The build base is used in CI already as the build root [1] (and it is open to the public which should cause no troubles to the Flux build). We should keep the CI build and the production build as close as possible if not identical [2]. Cincinnati is not an OCP product but the theory there can be applied. The builder image is currently not based from ubi-minimal [3]. We could switch to it, e.g., when making the next build root image for a new Rust version. In addition, the recipe `just build --release` is used to build the binaries, to keep doing things in a consistent way. [1]. https://github.com/openshift/release/blob/76d0cff0192e04c1d90a535d72106bffab91e79a/ci-operator/config/openshift/cincinnati/openshift-cincinnati-master.yaml#L18-L22 [2]. https://docs.ci.openshift.org/architecture/images/ [3]. https://github.com/openshift/release/blob/76d0cff0192e04c1d90a535d72106bffab91e79a/ci-operator/config/openshift/cincinnati/openshift-cincinnati-master.yaml#L26

openshift#1067 uses the ubi-minimal images. > We do not need to update the base image in the build stage, but I do not see a reason why we should not use the minimal for all stages while we are at it. This pull gives a reason: It saves the dependency installation in each CI build. The build base is used in CI already as the build root [1] (and it is open to the public which should cause no troubles to the Flux build). We should keep the CI build and the production build as close as possible if not identical [2]. Cincinnati is not an OCP product but the theory there can be applied. The builder image is currently not based from ubi-minimal [3]. We could switch to it, e.g., when making the next build root image for a new Rust version. In addition, the recipe `just build --release` is used to build the binaries, to keep doing things in a consistent way. Basically this pull tries to reduce the change on CI from openshift/release#79424. [1]. https://github.com/openshift/release/blob/76d0cff0192e04c1d90a535d72106bffab91e79a/ci-operator/config/openshift/cincinnati/openshift-cincinnati-master.yaml#L18-L22 [2]. https://docs.ci.openshift.org/architecture/images/ [3]. https://github.com/openshift/release/blob/76d0cff0192e04c1d90a535d72106bffab91e79a/ci-operator/config/openshift/cincinnati/openshift-cincinnati-master.yaml#L26

openshift#1067 uses the ubi-minimal images. > We do not need to update the base image in the build stage, but I do not see a reason why we should not use the minimal for all stages while we are at it. This pull gives a reason: It saves the dependency installation in each CI build. The build base is used in CI already as the build root [1] (and it is open to the public which should cause no troubles to the Flux build). We should keep the CI build and the production build as close as possible if not identical [2]. Cincinnati is not an OCP product but the theory there can be applied. The builder image is currently not based from ubi-minimal [3]. We could switch to it, e.g., when making the next build root image for a new Rust version. In addition, the recipe `just build --release` is used to build the binaries, to keep doing things in a consistent way. Basically this pull tries to reduce the changes on CI from openshift/release#79424. [1]. https://github.com/openshift/release/blob/76d0cff0192e04c1d90a535d72106bffab91e79a/ci-operator/config/openshift/cincinnati/openshift-cincinnati-master.yaml#L18-L22 [2]. https://docs.ci.openshift.org/architecture/images/ [3]. https://github.com/openshift/release/blob/76d0cff0192e04c1d90a535d72106bffab91e79a/ci-operator/config/openshift/cincinnati/openshift-cincinnati-master.yaml#L26

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2026

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2026

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2026

chore(Dockerfile): Use ubi-minimal for base images

2eccc77

Use microdnf because dnf is not available in the minimal image.

DavidHurta force-pushed the bump-base-image branch from 38a89a8 to 2eccc77 Compare May 18, 2026 22:36

DavidHurta changed the title ~~chore(Dockerfile): Use ubi-minimal for base images~~ OTA-1838: chore(Dockerfile): Use ubi-minimal for base images May 18, 2026

DavidHurta marked this pull request as ready for review May 18, 2026 22:37

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 18, 2026

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 18, 2026

openshift-ci Bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label May 18, 2026

wking approved these changes May 18, 2026

View reviewed changes

openshift-ci Bot assigned wking May 18, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2026

wking approved these changes May 18, 2026

View reviewed changes

openshift-merge-bot Bot merged commit d5c8259 into openshift:master May 18, 2026
9 checks passed

hongkailiu mentioned this pull request May 19, 2026

Simplify Dockerfile #1068

Open

Conversation

DavidHurta commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented May 15, 2026

Uh oh!

coderabbitai Bot commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

DavidHurta commented May 15, 2026

Uh oh!

DavidHurta commented May 15, 2026

Uh oh!

DavidHurta commented May 18, 2026

Uh oh!

DavidHurta commented May 18, 2026

Uh oh!

openshift-ci-robot commented May 18, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DavidHurta commented May 18, 2026

Uh oh!

coderabbitai Bot commented May 18, 2026

Chat

CodeRabbit commands

Other keywords and placeholders

Status, support, documentation and community

Uh oh!

DavidHurta commented May 18, 2026

Uh oh!

coderabbitai Bot commented May 18, 2026

Uh oh!

DavidHurta commented May 18, 2026

Uh oh!

coderabbitai Bot commented May 18, 2026

Uh oh!

openshift-ci Bot commented May 18, 2026

Uh oh!

DavidHurta commented May 18, 2026

Uh oh!

wking left a comment

Choose a reason for hiding this comment

Uh oh!

wking left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented May 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

DavidHurta commented May 15, 2026 •

edited

Loading

coderabbitai Bot commented May 15, 2026 •

edited

Loading

openshift-ci-robot commented May 18, 2026 •

edited by openshift-ci Bot

Loading