Skip to content

Remove Machine API manifest#37

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
spangenberg:cloudcredential-update-machine-api
Mar 4, 2019
Merged

Remove Machine API manifest#37
openshift-merge-robot merged 1 commit into
openshift:masterfrom
spangenberg:cloudcredential-update-machine-api

Conversation

@spangenberg
Copy link
Copy Markdown
Contributor

@spangenberg spangenberg commented Mar 1, 2019 •
edited
Loading

This file lives now under install/0000_30_machine-api-operator_00_credentials-request.yaml in machine-api-operator.

FYI: openshift/machine-api-operator#241

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 1, 2019
This was referenced Mar 1, 2019
Merged
Merged
@enxebre
Copy link
Copy Markdown
Member

enxebre commented Mar 1, 2019

I think this file can be removed from here now that we have https://github.com/openshift/machine-api-operator/blob/master/install/0000_30_machine-api-operator_00_credentials-request.yaml

@dgoodwin
Copy link
Copy Markdown
Contributor

dgoodwin commented Mar 1, 2019

Yeah that's correct, we should fix in your repo, and delete here.

@spangenberg
Copy link
Copy Markdown
Contributor Author

spangenberg commented Mar 1, 2019

@dgoodwin right now it looks like this file gets preferred over the other one during installation. If this one gets deleted will the other file in the MAO get picked up?

@dgoodwin
Copy link
Copy Markdown
Contributor

dgoodwin commented Mar 1, 2019

It likely applies them both, so one goes in first and then the next. It should be ok to remove this one.

@spangenberg
Copy link
Copy Markdown
Contributor Author

spangenberg commented Mar 1, 2019

Okay cool, I'll update the PR.

@spangenberg
Remove Machine API manifest
2989c1c 
This file lives now under install/0000_30_machine-api-operator_00_credentials-request.yaml in machine-api-operator.
@spangenberg spangenberg force-pushed the cloudcredential-update-machine-api branch from 0503314 to 2989c1c Compare March 1, 2019 19:02
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 1, 2019
@spangenberg spangenberg changed the title Add additional permissions to machine api credential request Remove Machine API manifest Mar 1, 2019
@enxebre
Copy link
Copy Markdown
Member

enxebre commented Mar 4, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2019
@frobware
Copy link
Copy Markdown

frobware commented Mar 4, 2019

/approve

1 similar comment
@dgoodwin
Copy link
Copy Markdown
Contributor

dgoodwin commented Mar 4, 2019

/approve

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, enxebre, frobware, spangenberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2019
@spangenberg
Copy link
Copy Markdown
Contributor Author

spangenberg commented Mar 4, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 7e9c06d into openshift:master Mar 4, 2019
ming1013 pushed a commit to ming1013/cloud-credential-operator that referenced this pull request Dec 15, 2025
@openshift-merge-robot
Merge pull request openshift#37 from spangenberg/cloudcredential-upda…
09b3d6b 
…te-machine-api

Remove Machine API manifest
This was referenced May 9, 2026
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abutcher abutcher Awaiting requested review from abutcher

@twiest twiest Awaiting requested review from twiest

Assignees

@enxebre enxebre

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@spangenberg @enxebre @dgoodwin @frobware @openshift-ci-robot @openshift-merge-robot