Skip to content

OCPBUGS-66346: [release-4.16] Fix capacity calculation #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 3 commits into from
Dec 11, 2025
Merged

OCPBUGS-66346: [release-4.16] Fix capacity calculation #195

openshift-merge-bot merged 3 commits into from
Dec 11, 2025

Conversation

@kyrtapz
Copy link
Contributor

@kyrtapz kyrtapz commented Dec 3, 2025

Conflicts:
pkg/cloudprovider/cloudprovider.go

@kyrtapz
Fix capacity calculation
c569bd6 
The previous capacity calculation incorrectly only counted CloudPrivateIPConfigs
that had the status set. This is racy and can lead to artificially reduced capacity.
Fix it by accounting for all CloudPrivateIPConfigs that are or were assigned to
the matching node.

Change the calculation in openstack to only consider IPs that were assigned to the
port by using `allowed_address_pairs`.

Conflicts:
pkg/cloudprovider/cloudprovider.go

Signed-off-by: Patryk Diak <pdiak@redhat.com>
(cherry picked from commit 0739734)
Signed-off-by: Patryk Diak <pdiak@redhat.com>
(cherry picked from commit f0e5761)
(cherry picked from commit 7230ff4)
@kyrtapz
GCP: Lock node operations
ebcb3bb 
To avoid the following error being returned
when trying to add/remove multiple IPs at once:
  err: googleapi: Error 412: Invalid fingerprint.

From the docs:
  The request will fail with error 400 Bad Request if the fingerprint is not provided,
  or 412 Precondition Failed if the fingerprint is out of date.

Signed-off-by: Patryk Diak <pdiak@redhat.com>
(cherry picked from commit 55a735a)
(cherry picked from commit da6528b)
(cherry picked from commit 84f8e6d)
@kyrtapz
Cleanup in-memory node state on node removal
df928f4 
Signed-off-by: Patryk Diak <pdiak@redhat.com>
(cherry picked from commit e096199)
(cherry picked from commit 1456ea2)
(cherry picked from commit a8ef798)
@coderabbitai
Copy link

coderabbitai bot commented Dec 3, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@kyrtapz
Copy link
Contributor Author

kyrtapz commented Dec 3, 2025

/jira cherry-pick OCPBUGS-66132

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 3, 2025

@kyrtapz: Jira Issue OCPBUGS-66132 has been cloned as Jira Issue OCPBUGS-66346. Will retitle bug to link to clone.
/retitle OCPBUGS-66346: [release-4.16] Fix capacity calculation

In response to this:

/jira cherry-pick OCPBUGS-66132

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.16] Fix capacity calculation OCPBUGS-66346: [release-4.16] Fix capacity calculation Dec 3, 2025
@openshift-ci openshift-ci bot requested review from abhat and andreaskaris December 3, 2025 15:59
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Dec 3, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 3, 2025

@kyrtapz: This pull request references Jira Issue OCPBUGS-66346, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.z) matches configured target version for branch (4.16.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-66132 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-66132 targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Conflicts:
pkg/cloudprovider/cloudprovider.go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kyrtapz
Copy link
Contributor Author

kyrtapz commented Dec 3, 2025

@anuragthehatter @ricky-rav ptal

@huiran0826
Copy link

huiran0826 commented Dec 8, 2025

/verified by @huiran0826

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 8, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 8, 2025

@huiran0826: This PR has been marked as verified by @huiran0826.

In response to this:

/verified by @huiran0826

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ricky-rav
ricky-rav approved these changes Dec 10, 2025
View reviewed changes
Copy link
Contributor

@ricky-rav ricky-rav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2025
@kyrtapz
Copy link
Contributor Author

kyrtapz commented Dec 10, 2025

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 10, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyrtapz, ricky-rav

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 10, 2025

/retest-required

Remaining retests: 0 against base HEAD d24b0f0 and 2 for PR HEAD df928f4 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 10, 2025 •
edited
Loading

@kyrtapz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security df928f4 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kyrtapz
Copy link
Contributor Author

kyrtapz commented Dec 11, 2025

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit b3854cc into openshift:release-4.16 Dec 11, 2025
8 of 9 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 11, 2025

@kyrtapz: Jira Issue Verification Checks: Jira Issue OCPBUGS-66346
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-66346 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

Conflicts:
pkg/cloudprovider/cloudprovider.go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhat abhat Awaiting requested review from abhat

@andreaskaris andreaskaris Awaiting requested review from andreaskaris

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

1 more reviewer

@ricky-rav ricky-rav ricky-rav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ricky-rav ricky-rav

@mffiedler mffiedler

@rbbratta rbbratta

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@qiowang721 qiowang721

@Meina-rh Meina-rh

@barbora137 barbora137

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.