Skip to content

NO-JIRA bump google.golang.org/grpc@v1.79.3#382

Open
sbiradar10 wants to merge 1 commit intoopenshift:mainfrom
sbiradar10:master
Open

NO-JIRA bump google.golang.org/grpc@v1.79.3#382
sbiradar10 wants to merge 1 commit intoopenshift:mainfrom
sbiradar10:master

Conversation

@sbiradar10
Copy link
Copy Markdown

@sbiradar10 sbiradar10 commented May 6, 2026

bump google.golang.org/grpc@v1.79.3

Summary by CodeRabbit

  • Chores
    • Updated multiple Go module dependencies for stability and performance improvements, including golang.org/x/sys, golang.org/x/term, and google.golang.org/grpc.
    • Added OpenTelemetry-related dependencies to support enhanced observability and monitoring capabilities.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 6, 2026

Caution

Review failed

Failed to post review comments

Walkthrough

Go module dependencies are updated in go.mod, including direct updates to golang.org/x/sys, golang.org/x/term, and google.golang.org/grpc, alongside new OpenTelemetry-related indirect dependencies and supporting module version bumps.

Changes

Go Module Dependency Updates

Layer / File(s) Summary
Direct Dependencies
go.mod (lines 24–26)
Three direct dependencies updated: golang.org/x/sys to v0.39.0, golang.org/x/term to v0.38.0, and google.golang.org/grpc to v1.79.3.
Indirect Dependency Refresh
go.mod (lines 60, 163–183)
Indirect dependency cel.dev/expr updated from v0.24.0 to v0.25.1. Large set of new OpenTelemetry indirect dependencies added at v1.39.0 (go.opentelemetry.io/*, otlp exporters, protobufs). Supporting indirect dependencies updated: golang.org/x/crypto (v0.46.0, v0.30.0), golang.org/x/mod (v0.30.0), golang.org/x/net (v0.48.0), golang.org/x/oauth2 (v0.34.0), golang.org/x/sync (v0.19.0), golang.org/x/text (v0.32.0), golang.org/x/tools (v0.39.0), and corresponding generated proto versions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 10 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title focuses on bumping google.golang.org/grpc to v1.79.3, but the changeset includes many additional dependency updates (OpenTelemetry libraries, golang.org/x modules, etc.), making the title incomplete and not fully representative of the main changes. Revise the title to reflect the broader scope, such as 'Update Go dependencies including gRPC v1.79.3 and OpenTelemetry libraries' or provide a more accurate summary of all significant changes.
Topology-Aware Scheduling Compatibility ⚠️ Warning Manifests use nodeSelector/affinity targeting control-plane nodes without topology checks, causing HyperShift deployments to fail where no control-plane nodes exist in-cluster. Add ControlPlaneTopology detection. Use preferredDuringScheduling instead of required affinity. Avoid hardcoding control-plane node selectors that break on HyperShift.
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only modifies dependencies (go.mod, go.sum, vendor/). No test files are added or modified. Custom check for Ginkgo test name stability is not applicable as there are no test code changes to review.
Test Structure And Quality ✅ Passed This PR only modifies go.mod and dependency files. No Ginkgo test code was added or modified, making this check not applicable to this PR.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests added. PR is a dependency bump for google.golang.org/grpc v1.79.3. No Ginkgo test patterns (It, Describe, Context, When) were introduced.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR adds Go unit tests using standard testing package, not Ginkgo e2e tests. Custom check only applies to Ginkgo tests (It(), Describe(), Context(), When()). This is a dependency update commit.
Ote Binary Stdout Contract ✅ Passed OTE Binary Stdout Contract check not applicable. This is Cloud Provider OpenStack, not an OpenShift Tests Extension binary. No OTE patterns present.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Custom check is not applicable. The PR only updates Go module dependencies in go.mod/go.sum and does not add or modify any Ginkgo e2e tests. The check only applies when new tests are added.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Microsoft Presidio Analyzer (2.2.362)
go.mod

Microsoft Presidio Analyzer failed to scan this file


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from mandre and stephenfin May 6, 2026 15:11
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 6, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sbiradar10
Once this PR has been reviewed and has the lgtm label, please assign gnufied for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbiradar10
Copy link
Copy Markdown
Author

/retest-required

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 6, 2026

@sbiradar10: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 032345e link false /test security
ci/prow/e2e-openstack 032345e link true /test e2e-openstack

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant