Merge https://github.com/kubernetes-sigs/cluster-api-operator:v0.5.0 (d9e33a9) into main#23
Closed
damdo wants to merge 80 commits intoopenshift:mainfrom
Closed
Merge https://github.com/kubernetes-sigs/cluster-api-operator:v0.5.0 (d9e33a9) into main#23damdo wants to merge 80 commits intoopenshift:mainfrom
damdo wants to merge 80 commits intoopenshift:mainfrom
Conversation
🌱 Update helm chart index.yaml
🌱 Enable nestif linter again
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.50.1 to 1.53.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.50.1...v1.53.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…t/go_modules/hack/chart-update/google.golang.org/grpc-1.53.0 🌱 build(deps): bump google.golang.org/grpc from 1.50.1 to 1.53.0 in /hack/chart-update
✨Fetch latest provider version if it's not set in the spec
To work properly CAPI Operator needs cert-manager. To ensure it is installed, we add a cert-manager dependency to the helm chart.
Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.9.0 to 0.10.0. - [Commits](golang/oauth2@v0.9.0...v0.10.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…t/go_modules/golang.org/x/oauth2-0.10.0 🌱 bump golang.org/x/oauth2 from 0.9.0 to 0.10.0
✨ Add cert-manager as a dependency to helm-chart
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
✨Bump go version to v1.20.4
Now we compile it twice, which seems unnecessary.
🌱 compile capi operator binary only once in the Dockerfile
🌱 Bump Cluster API to v1.5.0-rc.0
✨ Create operator CRs based on helm values
When you try to install a Core Provider with name different from "cluster-api", clusterctl validation fails: https://github.com/kubernetes-sigs/cluster-api/blob/main/cmd/clusterctl/client/config/providers_client.go#L414-L416 After that CAPI operator puts a vague error description in the logs and doesn't add anything meaningful to the provider status. To improve it, we add a new pre-flight check to compare Core Provider name with the desired one, and fail earlier, updating the status with correct information.
🌱 Add a preflight check to validate core provider name
…suite 🌱 Refactor tests to be more readable and have better logging
# Conflicts: # .github/workflows/golangci-lint.yml # OWNERS_ALIASES # Conflicts: # .github/workflows/golangci-lint.yml # OWNERS_ALIASES # Conflicts: # .github/workflows/golangci-lint.yml # OWNERS_ALIASES # Conflicts: # .github/workflows/golangci-lint.yml # .github/workflows/verify.yml # OWNERS_ALIASES # Conflicts: # .github/workflows/golangci-lint.yml
…ges to be consistent with ART
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Member
Author
|
/retest |
|
@damdo: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Member
Author
|
Close in favour of #25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.