-
Notifications
You must be signed in to change notification settings - Fork 23
Bug 1745772: [openshift-4.2-cluster-api-0.1.0] pkg/drain: always honor pod termination timeout #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… timeout Honoring the drain's library termination timeout can cause unnecessary timeout on delete. The MCO is wronly setting a 600s termination timeout for every pod which is wrong. Fix MCO and any other user who might have set an hard timeout exceeding the pod's termination timeout. Signed-off-by: Antonio Murdaca <runcom@linux.com>
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1758343, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retitle Bug 1745772: [openshift-4.2-cluster-api-0.1.0] Bug 1758343: pkg/drain: always honor pod termination timeout |
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1745772, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retitle Bug 1745772: [openshift-4.2-cluster-api-0.1.0] pkg/drain: always honor pod termination timeout /retest |
|
/bugzilla refresh |
|
@runcom: This pull request references Bugzilla bug 1745772, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
The bug referenced was closed, so was this PR required for the BZ? We need a new one. Do we have something that fixes this in 4.3/master? We're also going to need review/lgtm/approval from the team. |
|
/hold |
This has been fixed in 4.2 with openshift/machine-config-operator#1154 so we don't necessarily need this and we can close it (and the BZ as well), I don't have power to close this tho |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #130
/assign runcom