Skip to content

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #130

/assign runcom

… timeout

Honoring the drain's library termination timeout can cause unnecessary
timeout on delete.
The MCO is wronly setting a 600s termination timeout for every pod which
is wrong.
Fix MCO and any other user who might have set an hard timeout exceeding
the pod's termination timeout.

Signed-off-by: Antonio Murdaca <runcom@linux.com>
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1758343, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[openshift-4.2-cluster-api-0.1.0] Bug 1758343: pkg/drain: always honor pod termination timeout

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 4, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign frobware
You can assign the PR to them by writing /assign @frobware in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 4, 2019
@runcom
Copy link
Member

runcom commented Oct 4, 2019

/retitle Bug 1745772: [openshift-4.2-cluster-api-0.1.0] Bug 1758343: pkg/drain: always honor pod termination timeout

@openshift-ci-robot openshift-ci-robot changed the title [openshift-4.2-cluster-api-0.1.0] Bug 1758343: pkg/drain: always honor pod termination timeout Bug 1745772: [openshift-4.2-cluster-api-0.1.0] Bug 1758343: pkg/drain: always honor pod termination timeout Oct 4, 2019
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1745772, which is invalid:

  • expected dependent Bugzilla bug 1758343 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1745772: [openshift-4.2-cluster-api-0.1.0] Bug 1758343: pkg/drain: always honor pod termination timeout

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@runcom
Copy link
Member

runcom commented Oct 4, 2019

/retitle Bug 1745772: [openshift-4.2-cluster-api-0.1.0] pkg/drain: always honor pod termination timeout

/retest

@openshift-ci-robot openshift-ci-robot changed the title Bug 1745772: [openshift-4.2-cluster-api-0.1.0] Bug 1758343: pkg/drain: always honor pod termination timeout Bug 1745772: [openshift-4.2-cluster-api-0.1.0] pkg/drain: always honor pod termination timeout Oct 4, 2019
@runcom
Copy link
Member

runcom commented Oct 6, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link

@runcom: This pull request references Bugzilla bug 1745772, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eparis
Copy link
Member

eparis commented Oct 26, 2019

The bug referenced was closed, so was this PR required for the BZ? We need a new one. Do we have something that fixes this in 4.3/master? We're also going to need review/lgtm/approval from the team.

@enxebre
Copy link
Member

enxebre commented Dec 9, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2019
@runcom
Copy link
Member

runcom commented Jan 30, 2020

The bug referenced was closed, so was this PR required for the BZ? We need a new one. Do we have something that fixes this in 4.3/master? We're also going to need review/lgtm/approval from the team.

This has been fixed in 4.2 with openshift/machine-config-operator#1154 so we don't necessarily need this and we can close it (and the BZ as well), I don't have power to close this tho

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 26, 2020
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 27, 2020
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants