add 'single-node-production-edge' annotations to CVO manifests. #384
Conversation
|
Please explain in details of what the annotation actually does in the commit message, link to an enhancement won't do for anyone who wants to quickly understand why the annotation's there. I haven't read the enhancement and I do not know the consequences of this annotation. Single-node cluster sounds contradictive. Does that mean the operator's code will need to change? Who is going to implement the necessary changes? How is this different from the other "single-node" PR? Why does it have to be 2 PRs instead of one with two commits? |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
@stlaz updated description, please take a look |
|
/retest |
|
@osherdp Awesome, please also remove the JIRA reference from the commit message. I am also concerned about
What does it mean "will match a non high-availability profile"? CAO makes assumptions about high-availability of kube-apiserver as it may restart it as a reaction to user configuration. What happens to the platform when there is no kube-apiserver? How do you make this component "match a non high-availability profile"? Is that something that will require changes to the component? Who will implement them? |
osherdp
force-pushed
the
enhancement/single-node-annotation
branch
from
e8a694d to
d181e7d
Compare
|
@stlaz not only CAO, but many components are doing restarts. We have MCO which also does a complete node reboot and we do know to handle that |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: osherdp, stlaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
lgtm
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
osherdp
force-pushed
the
enhancement/single-node-annotation
branch
from
d181e7d to
fbe5bbf
Compare
|
New changes are detected. LGTM label has been removed. |
|
/retest |
|
/hold for openshift/api#813 |
openshift-ci-robot
added
the
do-not-merge/hold
osherdp
changed the title
|
/hold |
this matches openshift/enhancements#504 and doesn't change existing behavior
osherdp
force-pushed
the
enhancement/single-node-annotation
branch
from
a8a4963 to
d4bfe6c
Compare
|
@stlaz done |
|
/retest |
|
Shifting strategy based on openshift/enhancements#560 |
4 participants
This PR adds annotation for the single-node-production-edge cluster profile. There's a growing requirement from several customers to enable creation of single-node (not high-available) Openshift clusters.
In stage one (following openshift/enhancements#504) there should be no implication on components logic.
In the next stage, the component's behavior will match a non high-availability profile if the customer is specifically interested in one.
This PR is separate from the 'single-node-developer' work, which will implement a different behavior and is currently on another stage of implementation.
For more info, please refer to the enhancement link and participate in the discussion.