CNTRLPLANE-2589: update cases to execute as parallel#833
CNTRLPLANE-2589: update cases to execute as parallel#833ropatil010 wants to merge 2 commits intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@ropatil010: This pull request references CNTRLPLANE-2589 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughRelabels tests from [Serial] to [Parallel] and renames the suite path from "serial" to "parallel". README usage examples updated to show a parallel run (4 workers) and adjusted JUnit output/suite listing. One test runner binary change updates the tag predicate to match "[Parallel]" (parallelism flag unchanged in that binary). Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ropatil010 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Makefile
Outdated
| test-e2e: GO_TEST_FLAGS += -v | ||
| test-e2e: GO_TEST_FLAGS += -timeout 1h | ||
| test-e2e: GO_TEST_FLAGS += -count 1 | ||
| test-e2e: GO_TEST_FLAGS += -p 1 |
There was a problem hiding this comment.
I think that we should make the test suite parallel instead of serial
running test in parallel is better because it usually requires less time to complete the test suite.
There was a problem hiding this comment.
Sure,
As per analysis of the cases : openshift/origin#30735 (comment)
i have added serial tag. Let me update to parallel and monitor the case results.
There was a problem hiding this comment.
As per earlier suggestion openshift/origin#30735 (comment) used serial execution of cases.
But per latest suggestion #833 (comment), added parallel execution things.
Changes: - Remove serial test suite from main.go, keep only parallel suite with Parallelism: 4 - Update all e2e test tags from [Serial] to [Parallel]: - certs.go: [Operator][Certs][Parallel] - custom_route.go: [Operator][Routes][Parallel] - gitlab.go: [OIDC][Parallel] - keycloak.go: [OIDC][Parallel] - templates.go: [Templates][Parallel] - tokentimeout.go: [Tokens][Parallel] - Update README.md to reference parallel suite instead of serial This enables parallel test execution with 4 workers for better performance. Co-Authored-By: Rohit Patil <ropatil@redhat.com>
ropatil010
force-pushed
the
update-makefile
branch
from
ae0cb8a to
e6aa488
Compare
ropatil010
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@cmd/cluster-authentication-operator-tests-ext/main.go`:
- Around line 63-68: The suite defined via
extension.AddSuite(oteextension.Suite) with Name
"openshift/cluster-authentication-operator/operator/parallel" uses Parallelism:
4 and a Qualifiers filter that includes cluster-mutating specs (e.g.,
TestTokenInactivityTimeout, TestTemplatesConfig, TestCustomRouterCerts,
TestRouterCerts), which risks races; fix by removing stateful tests from this
parallel suite and either (A) create a new serial suite (oteextension.Suite with
Parallelism: 1 and a distinct Name like ".../serial") whose Qualifiers select
those specific tests, or (B) reduce Parallelism to 1 and/or add Ginkgo
SerialSynchronized/Serial labels on the stateful tests to ensure exclusive
access to cluster-wide resources; update the Qualifiers string or test labels
accordingly so parallel workers no longer run read-modify-write cluster tests
concurrently.
|
@ropatil010: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
which Ci job runs the tests via OTE ? |
This is the PR: openshift/release#73999 wrt the CI job for OTE execution. |
Before migrating the tests, we should have this job running in this repository. I would update 73999 to use |
3 participants
Hi @p0lyn0mial
Can you PTAL on this PR.
Current PR is blocked bec of this: openshift/origin#30735