Skip to content

NO-JIRA: Add control-plane-approvers to OWNERS#127

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
kevinrizza:add-control-plane-approvers
Apr 27, 2026
Merged

NO-JIRA: Add control-plane-approvers to OWNERS#127
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
kevinrizza:add-control-plane-approvers

Conversation

@kevinrizza
Copy link
Copy Markdown
Member

@kevinrizza kevinrizza commented Apr 17, 2026

Add control-plane-approvers to OWNERS

Summary by CodeRabbit

  • Chores
    • Updated code review workflow configuration with organizational improvements to reviewer and approver assignment processes.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 17, 2026

Walkthrough

Two files were modified to refactor code approval workflows: the OWNERS file was updated to replace specific user entries with a group alias reference, and a new OWNERS_ALIASES file was created to define the control-plane-approvers group containing multiple usernames.

Changes

Cohort / File(s) Summary
OWNERS Configuration
OWNERS
Removed 7 specific user entries from approvers and 4 from reviewers lists; added control-plane-approvers group alias to both sections while retaining sanchezl.
OWNERS Aliases
OWNERS_ALIASES
New file created defining the control-plane-approvers alias with a list of 14 GitHub usernames for centralized approval group management.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed This PR only modifies OWNERS and OWNERS_ALIASES configuration files, not any Ginkgo test files, so the custom check for test names is not applicable.
Test Structure And Quality ✅ Passed The PR modifies only OWNERS and OWNERS_ALIASES configuration files with no Ginkgo test code to review.
Microshift Test Compatibility ✅ Passed The pull request does not add any Ginkgo e2e tests. The test files added are standard Go unit tests using the testing package, not Ginkgo e2e tests.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This pull request only modifies OWNERS and OWNERS_ALIASES configuration files, which are governance files. No Ginkgo e2e tests are added or modified, making the SNO Test Compatibility check inapplicable.
Topology-Aware Scheduling Compatibility ✅ Passed Pull request modifies only OWNERS and OWNERS_ALIASES files containing no deployment manifests, operator code, controllers, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed PR modifies only configuration files (OWNERS, OWNERS_ALIASES) with no executable code changes, making the check not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This pull request does not add any Ginkgo e2e tests. The changes are limited to OWNERS and OWNERS_ALIASES configuration files. Since the custom check applies only to new Ginkgo e2e tests, the check is not applicable and passes by default.
Title check ✅ Passed The title 'NO-JIRA: Add control-plane-approvers to OWNERS' accurately describes the main change: adding a new group alias to the OWNERS file and updating both approvers and reviewers lists.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from dgrisonnet and sanchezl April 17, 2026 16:27
@kevinrizza
Copy link
Copy Markdown
Member Author

/retitle NO-JIRA: Add control-plane-approvers to OWNERS

@openshift-ci openshift-ci Bot changed the title Add control-plane-approvers to OWNERS NO-JIRA: Add control-plane-approvers to OWNERS Apr 17, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 17, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@kevinrizza: This pull request explicitly references no jira issue.

Details

In response to this:

Add control-plane-approvers to OWNERS

Summary by CodeRabbit

  • Chores
  • Updated code review workflow configuration with organizational improvements to reviewer and approver assignment processes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 17, 2026

@kevinrizza: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sanchezl
Copy link
Copy Markdown

/lgtm
/verified bypass

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 27, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@sanchezl: The verified label has been added.

Details

In response to this:

/lgtm
/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevinrizza, sanchezl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 96db857 into openshift:main Apr 27, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants