Skip to content

Sdk bump v0.0.7 => v0.7.0 #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 17, 2019
Merged

Sdk bump v0.0.7 => v0.7.0 #159

merged 2 commits into from
May 17, 2019

Conversation

@ewolinetz
Copy link
Contributor

@ewolinetz ewolinetz commented Apr 24, 2019

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2019
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 24, 2019
@ewolinetz
Copy link
Contributor Author

ewolinetz commented Apr 24, 2019

/test e2e-operator

@ewolinetz
Copy link
Contributor Author

ewolinetz commented Apr 24, 2019

currently troubleshooting adding the elasticsearch scheme for the operator to run

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 25, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2019
@ewolinetz ewolinetz requested review from jcantrill and josefkarasek and removed request for brancz May 6, 2019 16:23
@richm
Copy link
Contributor

richm commented May 7, 2019

/test e2e-operator

@ewolinetz
Copy link
Contributor Author

ewolinetz commented May 7, 2019

/retest

1 similar comment
@ewolinetz
Copy link
Contributor Author

ewolinetz commented May 7, 2019

/retest

@ewolinetz ewolinetz changed the title [WIP] Sdk bump v0.0.7 => v0.7.0 Sdk bump v0.0.7 => v0.7.0 May 8, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2019
@ewolinetz
Copy link
Contributor Author

ewolinetz commented May 9, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2019
@ewolinetz
Copy link
Contributor Author

ewolinetz commented May 9, 2019

looks like fluentd isn't correctly being deployed/tested as part of the ci and this is hidden due to running tests in parallel. tests will begin to start failing for e2e-operator please do not retest

@ewolinetz ewolinetz force-pushed the sdk_bump branch 4 times, most recently from c88f30d to f73db61 Compare May 9, 2019 20:51
jcantrill
jcantrill approved these changes May 13, 2019
View reviewed changes
Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It LGTM. Only question i have is ability to mock the client for testing which would mean the CRUD methods on clusterloggingrequest would move to interface. If mocking is easier then unnecessary

@ewolinetz
Copy link
Contributor Author

ewolinetz commented May 13, 2019

@jcantrill I'm currently looking into how we can do mocking with our tests and can make that part of this PR.

@ewolinetz
Copy link
Contributor Author

ewolinetz commented May 13, 2019

/refresh

@ewolinetz
Copy link
Contributor Author

ewolinetz commented May 13, 2019

/retest

josefkarasek
josefkarasek reviewed May 14, 2019
View reviewed changes
josefkarasek
josefkarasek reviewed May 14, 2019
View reviewed changes
josefkarasek
josefkarasek reviewed May 14, 2019
View reviewed changes
@josefkarasek
Copy link

josefkarasek commented May 14, 2019

Outstanding job, Eric!! Really good!

I only stumbled upon some unexpected comments. Please run go fmt and we can merge.

@ewolinetz
Copy link
Contributor Author

ewolinetz commented May 14, 2019

I believe I need to update this PR to point to master instead of master-post-release

@ewolinetz ewolinetz changed the base branch from master-post-release to master May 16, 2019 15:42
@ewolinetz ewolinetz force-pushed the sdk_bump branch 2 times, most recently from af5b0b2 to 8c66f8d Compare May 16, 2019 16:31
@jcantrill
Copy link
Contributor

jcantrill commented May 17, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2019
@jcantrill
Copy link
Contributor

jcantrill commented May 17, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewolinetz, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ewolinetz,jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8566b0d into openshift:master May 17, 2019
pmoogi-redhat pushed a commit to pmoogi-redhat/cluster-logging-operator that referenced this pull request Apr 26, 2022
@openshift-merge-robot
Merge pull request openshift#159 from ewolinetz/sdk_bump
478863e 
Sdk bump v0.0.7 => v0.7.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcantrill jcantrill jcantrill approved these changes

@richm richm Awaiting requested review from richm

+1 more reviewer

@josefkarasek josefkarasek josefkarasek left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jcantrill jcantrill

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ewolinetz @richm @josefkarasek @jcantrill @openshift-ci-robot @openshift-merge-robot