SDK bump from v0.0.7 => v0.7.0 #122
Conversation
openshift-ci-robot
added
approved
|
/test e2e-aws |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
ewolinetz
requested review from
jcantrill and
josefkarasek
and removed request for
squat
jcantrill
left a comment
jcantrill
left a comment
There was a problem hiding this comment.
Generally lgtm. Only question I have is about files that seem to be duplicates which I assume are part of stubbing the new SDK. Should we remove them? I would be fine with a follow on clean up PR if it made sense.
| monitoringv1 "github.com/coreos/prometheus-operator/pkg/apis/monitoring/v1" | ||
| ) | ||
|
|
||
| // Change below variables to serve metrics on different host or port. |
There was a problem hiding this comment.
Artifact from stubbing the code? Do we need to act upon this?
There was a problem hiding this comment.
that is from the code generation. i don't think we need to act upon it unless we want to use a different port
|
|
||
| func init() { | ||
| // Register the types with the Scheme so the components can map objects to GroupVersionKinds and back | ||
| AddToSchemes = append(AddToSchemes, v1.SchemeBuilder.AddToScheme) |
There was a problem hiding this comment.
Would this allow us to watch multiple kinds?
There was a problem hiding this comment.
we would do that in the controller, but yes.
There was a problem hiding this comment.
|
I want to wait and cherry pick #120 onto this |
ewolinetz
force-pushed
the
sdk_bump
branch
4 times, most recently
from
df8f6f4 to
0b37c81
Compare
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ewolinetz, josefkarasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick master-post-release |
|
@richm: base branch (master-post-release) needs to differ from target branch (master-post-release) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7 participants
will need to rebase after #121 merges in
Replaces #118