Skip to content

Conversation

@jcantrill
Copy link
Contributor

This reverts commit b2384ab.

Description

This PR reverts the prior change after testing that existing deployments can successfully upgrade to 5.8. The implications here is existing deployments will need to adjust there operatorgroup to take full advantage of mCLF. Additionally it may be new deployments must explicitly choose "all namespaces" or will need to edit the operatorgroup in the future if they do not

Links

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 13, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 13, 2023

@jcantrill: This pull request references LOG-4607 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set.

In response to this:

This reverts commit b2384ab.

Description

This PR reverts the prior change after testing that existing deployments can successfully upgrade to 5.8. The implications here is existing deployments will need to adjust there operatorgroup to take full advantage of mCLF. Additionally it may be new deployments must explicitly choose "all namespaces" or will need to edit the operatorgroup in the future if they do not

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2023

@jcantrill: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jcantrill
Copy link
Contributor Author

cc @alanconway

@alanconway
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2023
@openshift-ci openshift-ci bot merged commit 33628cc into openshift:master Oct 16, 2023
@jcantrill jcantrill deleted the log4650 branch October 16, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. release/5.8

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants