Bug 1732585: Modify kibana-proxy to rely on ServiceAccount as oauthcl… #234
Conversation
|
@jcantrill: This pull request references Bugzilla bug 1732585, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
openshift-ci-robot
added
the
size/L
openshift-ci-robot
added
the
approved
| "-cookie-secret-file=/secret/session-secret", | ||
| "-upstream=http://localhost:5601", | ||
| "-scope=user:info user:check-access user:list-projects", | ||
| "-scope=user:info user:check-access", |
There was a problem hiding this comment.
we don't need list-projects here?
There was a problem hiding this comment.
I'm uncertain why this is here as the Kibana proxy never needed to list projects. All of that particular logic is in the openshift-elasticsearch-plugin.
There was a problem hiding this comment.
. . . and we won't know until the oal access control tests are run, and even then we won't know if this causes a regression unless we have some way to test Kibana in a wide variety of cases/situations . . .
I guess let's accept this change, and make sure we test as much as possible.
There was a problem hiding this comment.
backtracking here as https://bugzilla.redhat.com/show_bug.cgi?id=1746695 was introduced.. not understood why our access script doesnt expose it
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill, richm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jcantrill: All pull requests linked via external trackers have merged. Bugzilla bug 1732585 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Any cherrypick also needs #241 |
Bug 1732585: Modify kibana-proxy to rely on ServiceAccount as oauthcl…
4 participants
…ient
This bug resolves https://bugzilla.redhat.com/show_bug.cgi?id=1732585 by: