Skip to content

separately managed oauthclient object was removed #1738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2019
Merged

separately managed oauthclient object was removed #1738

merged 1 commit into from
Aug 27, 2019

Conversation

@richm
Copy link
Contributor

@richm richm commented Aug 27, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 27, 2019
@richm richm requested a review from jcantrill August 27, 2019 01:44
@richm richm added autoretest Please auto-retest this PR if one of the flaky tests fail kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/test-flake Categorizes issue or PR as related to test flakes. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release/4.2 labels Aug 27, 2019
@richm
Copy link
Contributor Author

richm commented Aug 27, 2019

openshift/cluster-logging-operator#234 removed the separate oauthclient object. We need to remove it from the test as well.

@richm richm mentioned this pull request Aug 27, 2019
Merged
@richm
Copy link
Contributor Author

richm commented Aug 27, 2019

tests passed - please lgtm to unblock ci

jcantrill
jcantrill approved these changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 27, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, richm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit fa2878e into openshift:master Aug 27, 2019
@richm richm deleted the ci-remove-oauthclient branch August 27, 2019 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcantrill jcantrill jcantrill approved these changes

@ewolinetz ewolinetz Awaiting requested review from ewolinetz

@nhosoi nhosoi Awaiting requested review from nhosoi

Assignees

@jcantrill jcantrill

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. autoretest Please auto-retest this PR if one of the flaky tests fail kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/test-flake Categorizes issue or PR as related to test flakes. lgtm Indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release/4.2 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@richm @openshift-ci-robot @jcantrill @openshift-merge-robot