Skip to content

update http functional test to test using password #2612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2024
Merged

update http functional test to test using password #2612

merged 1 commit into from
Jul 19, 2024

Conversation

@jcantrill
Copy link
Contributor

@jcantrill jcantrill commented Jul 3, 2024

Description

This PR:
Modifies the functional HTTP test to test using username and password

@openshift-ci openshift-ci bot requested review from Clee2691 and cahartma July 3, 2024 13:42
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2024
Clee2691
Clee2691 reviewed Jul 3, 2024
View reviewed changes
@jcantrill jcantrill force-pushed the add_password_test branch 2 times, most recently from f8f3b9a to 594ea70 Compare July 3, 2024 20:12
@Clee2691
Copy link
Contributor

Clee2691 commented Jul 3, 2024

/lgtm

@Clee2691
Copy link
Contributor

Clee2691 commented Jul 3, 2024

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 4, 2024

/retest-required

Remaining retests: 0 against base HEAD a44ff0f and 2 for PR HEAD 594ea70 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 4, 2024

/retest-required

Remaining retests: 0 against base HEAD 4d3bd5d and 1 for PR HEAD 594ea70 in total

@jcantrill
Copy link
Contributor Author

jcantrill commented Jul 4, 2024

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 5, 2024

/retest-required

Remaining retests: 0 against base HEAD c3ad145 and 0 for PR HEAD 594ea70 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 5, 2024

/hold

Revision 594ea70 was retested 3 times: holding

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 5, 2024

/retest-required

Remaining retests: 0 against base HEAD 4aa2ab7 and 2 for PR HEAD 594ea70 in total

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 5, 2024
@jcantrill
Copy link
Contributor Author

jcantrill commented Jul 6, 2024

/hold cancel
/retest

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 6, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 8, 2024

/retest-required

Remaining retests: 0 against base HEAD bf43c8f and 1 for PR HEAD 594ea70 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 8, 2024

/retest-required

Remaining retests: 0 against base HEAD dcc0e69 and 0 for PR HEAD 594ea70 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 8, 2024

/hold

Revision 594ea70 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2024
@jcantrill
Copy link
Contributor Author

jcantrill commented Jul 9, 2024

/test functional-target

@jcantrill jcantrill force-pushed the add_password_test branch from 594ea70 to cb794ee Compare July 10, 2024 13:29
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2024
@jcantrill jcantrill force-pushed the add_password_test branch from cb794ee to 2e2f336 Compare July 15, 2024 17:42
@jcantrill
Copy link
Contributor Author

jcantrill commented Jul 15, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2024
@jcantrill jcantrill force-pushed the add_password_test branch 2 times, most recently from 37fca48 to ee5d123 Compare July 16, 2024 21:20
@cahartma
Copy link
Contributor

cahartma commented Jul 17, 2024

needs a rebase

@jcantrill jcantrill force-pushed the add_password_test branch from ee5d123 to a898737 Compare July 17, 2024 13:12
@jcantrill
Copy link
Contributor Author

jcantrill commented Jul 17, 2024

/test functional-target

@jcantrill jcantrill force-pushed the add_password_test branch from a898737 to b3c7fb0 Compare July 18, 2024 20:55
cahartma
cahartma reviewed Jul 18, 2024
View reviewed changes
Copy link
Contributor

@cahartma cahartma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 18, 2024

/retest-required

Remaining retests: 0 against base HEAD ec88f35 and 2 for PR HEAD b3c7fb0 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 19, 2024

/retest-required

Remaining retests: 0 against base HEAD 169f3b3 and 1 for PR HEAD b3c7fb0 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 19, 2024

/retest-required

Remaining retests: 0 against base HEAD f975322 and 0 for PR HEAD b3c7fb0 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 19, 2024

/hold

Revision b3c7fb0 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2024
@jcantrill jcantrill force-pushed the add_password_test branch from b3c7fb0 to 46f6608 Compare July 19, 2024 12:46
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2024
@jcantrill
Copy link
Contributor Author

jcantrill commented Jul 19, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2024
cahartma
cahartma reviewed Jul 19, 2024
View reviewed changes
Copy link
Contributor

@cahartma cahartma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2024

@jcantrill: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 742be6d into openshift:master Jul 19, 2024
@jcantrill jcantrill deleted the add_password_test branch July 19, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Clee2691 Clee2691 Clee2691 left review comments

@cahartma cahartma cahartma left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Clee2691 Clee2691

@cahartma cahartma

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release/6.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jcantrill @Clee2691 @openshift-ci-robot @cahartma