Skip to content

Bug 1791336: Fix fluent metrics config to support ipv6 #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2020
Merged

Bug 1791336: Fix fluent metrics config to support ipv6 #333

merged 1 commit into from
Jan 23, 2020

Conversation

@jcantrill
Copy link
Contributor

@jcantrill jcantrill commented Jan 15, 2020

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 15, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 15, 2020

@jcantrill: This pull request references Bugzilla bug 1791336, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1791336: Fix fluent metrics config to support ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 15, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2020
@jcantrill
Copy link
Contributor Author

jcantrill commented Jan 16, 2020

/test e2e-operator

1 similar comment
@jcantrill
Copy link
Contributor Author

jcantrill commented Jan 16, 2020

/test e2e-operator

@jcantrill
Copy link
Contributor Author

jcantrill commented Jan 17, 2020

/retest

1 similar comment
@jcantrill
Copy link
Contributor Author

jcantrill commented Jan 17, 2020

/retest

ewolinetz
ewolinetz reviewed Jan 22, 2020
View reviewed changes
pkg/generators/forwarding/fluentd/fluent_conf_test.go
## ordered so that syslog always runs last...
<source>
@type prometheus
bind '::'
Copy link
Contributor

@ewolinetz ewolinetz Jan 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting

igor-karpukhin
igor-karpukhin approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@igor-karpukhin igor-karpukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 22, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: igor-karpukhin, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [igor-karpukhin,jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@igor-karpukhin
Copy link
Contributor

igor-karpukhin commented Jan 22, 2020

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ec11d6a into openshift:master Jan 23, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 23, 2020

@jcantrill: All pull requests linked via external trackers have merged. Bugzilla bug 1791336 has been moved to the MODIFIED state.

In response to this:

Bug 1791336: Fix fluent metrics config to support ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcantrill jcantrill deleted the bz1791336 branch January 23, 2020 13:25
@jcantrill
Copy link
Contributor Author

jcantrill commented Jan 23, 2020

/cherrypick release-4.3

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 23, 2020
Closed
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 23, 2020

@jcantrill: new pull request created: #342

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Jan 27, 2020
Merged
Merged
pmoogi-redhat pushed a commit to pmoogi-redhat/cluster-logging-operator that referenced this pull request Apr 26, 2022
@openshift-merge-robot
Merge pull request openshift#333 from jcantrill/bz1791336
afd85f0 
Bug 1791336: Fix fluent metrics config to support ipv6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nhosoi nhosoi Awaiting requested review from nhosoi

2 more reviewers

@ewolinetz ewolinetz ewolinetz left review comments

@igor-karpukhin igor-karpukhin igor-karpukhin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@igor-karpukhin igor-karpukhin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport/4.3 bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. release/4.4 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jcantrill @openshift-ci-robot @igor-karpukhin @openshift-bot @openshift-cherrypick-robot @ewolinetz @openshift-merge-robot