LOG-1108: ClusterName for CloudWatch feature #910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcantrill
reviewed
Feb 22, 2021
igor-karpukhin
force-pushed
the
feature/LOG-1108-cw-cluster-name
branch
from
929b018 to
d4ece78
Compare
jcantrill
reviewed
Feb 23, 2021
Contributor
There was a problem hiding this comment.
looks like the validations are still missing from the CRD. make check maybe?
Contributor
Author
There was a problem hiding this comment.
Sorry. Fixed.
openshift-ci-robot
added
do-not-merge/hold
Contributor
|
/retest |
igor-karpukhin
force-pushed
the
feature/LOG-1108-cw-cluster-name
branch
from
d4ece78 to
abb843e
Compare
Contributor
|
/hold cancel |
openshift-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: igor-karpukhin, jcantrill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pmoogi-redhat
pushed a commit
to pmoogi-redhat/cluster-logging-operator
that referenced
this pull request
Apr 26, 2022
…-cw-cluster-name LOG-1108: ClusterName for CloudWatch feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CLO will try to autodetect cluster name for the CloudWatch log group prefix
/cc @jcantrill
/assign @jcantrill @vimalk78
Links