-
Notifications
You must be signed in to change notification settings - Fork 384
Bug 1723713: pkg/client: add support for relatedObjects in status report #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1723713: pkg/client: add support for relatedObjects in status report #373
Conversation
s-urbaniak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paulfantom, s-urbaniak The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.1 |
|
/cherrypick release-4.1 |
|
@paulfantom: new pull request created: #375 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@paulfantom: This pull request references a valid Bugzilla bug. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@paulfantom: This pull request references a valid Bugzilla bug. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Status report based on https://github.com/openshift/cluster-kube-apiserver-operator/blob/master/pkg/operator/starter.go#L123-L129
This should pass following test: https://github.com/openshift/origin/blob/master/test/extended/operators/clusteroperators.go#L60-L77
After merging this should be cherry-picked to release-4.1 branch.
/cc @s-urbaniak