[release-4.22] OCPBUGS-83637: only report Progressing for active network rollouts#2962
Conversation
Keep pod-based Progressing tied to an actual CNO rollout instead of temporary unavailability during node reboot churn. Detect rollouts with a simple two-phase approach: - Before install complete: all pod churn is part of the rollout - After install complete: rollout is active only when UpdatedXXX < CurrentXXX/Replicas Once Updated >= Current, treat pod unavailability as node reboot churn rather than network rollout progress, avoiding false Progressing conditions. Restore install-complete state safely across upgrades by treating older last-seen annotations that omit InstallComplete as legacy data instead of assuming install is incomplete again. For machine config status, stop treating generic MCP node convergence as a CNO rollout signal. Reuse shared mcutil helpers for source-only checks, and only prune removed machine-config state after every matching non-paused pool has dropped that config from its rendered source. Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com> Co-authored-by: Codex
|
@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: CORENET-6572 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retitle [release-4.22] CORENET-6992: only report Progressing for active network rollouts |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@openshift-cherrypick-robot: This pull request references CORENET-6992 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira-refresh |
3 similar comments
|
/jira-refresh |
|
/jira-refresh |
|
/jira-refresh |
|
/retest |
|
@danwinship this is just the backport since we missed getting the original PR in time before branch cutting. |
|
/retitle [release-4.22] OCPBUGS-83637: only report Progressing for active network rollouts |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/invalid-bug
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-83637, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira-refresh |
|
/retest |
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
This is an automated cherry-pick of #2937
/assign jluhrsen