NO-JIRA: Remove --enable-interconnect flag from OVN-K manifests

[kyrtapz]

We should drop the second commit once we sync the upstream changes into openshift/ovn-kubernetes.
It is required today so ovn-k works in both scenarios.

Summary by CodeRabbit

• Bug Fixes
  • Improved compatibility with different OVN-Kubernetes image versions by making the interconnect feature conditional on runtime support detection. The system now probes for feature availability before enabling interconnect functionality, preventing startup failures when the feature is unavailable.

[coderabbitai]

Walkthrough

This PR replaces unconditional passing of the --enable-interconnect flag across OVN-kubernetes manifests and startup scripts with runtime detection. Each component now probes the binary's --help output to detect support before conditionally passing the flag. The corresponding ConfigMap-based utility function for interconnect configuration is removed from Go utilities.

Changes

Conditional interconnect flag detection

Layer / File(s)	Summary
Node-identity webhook conditional interconnect flag bindata/network/node-identity/managed/node-identity.yaml, bindata/network/node-identity/self-hosted/node-identity.yaml	Both managed and self-hosted node-identity manifests add shell logic to detect if ovnkube-identity binary supports --enable-interconnect by checking help output, storing the result in enable_interconnect_flag, and passing the conditional variable to the exec invocation.
Control-plane conditional interconnect flag bindata/network/ovn-kubernetes/managed/ovnkube-control-plane.yaml, bindata/network/ovn-kubernetes/self-hosted/ovnkube-control-plane.yaml	Both managed and self-hosted ovnkube-control-plane manifests add shell logic to probe ovnkube binary help output for --enable-interconnect support, conditionally set enable_interconnect_flag, and update the exec invocation to use the computed flag instead of always including --enable-interconnect.
Script library conditional interconnect flag in node startup bindata/network/ovn-kubernetes/common/008-script-lib.yaml	The shared start-ovnkube-node() function in the script library detects ovnkube binary support for --enable-interconnect by probing help output and conditionally sets enable_interconnect_flag for use in the command invocation.
Remove obsolete interconnect ConfigMap utility pkg/util/util.go	The exported GetInterConnectConfigMap function and OVN_INTERCONNECT_CONFIGMAP_NAME constant are removed from pkg/util/util.go. Unused Kubernetes client and metav1 imports are cleaned up, leaving only the ReadMTUConfigMap logic and necessary dependencies.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	This PR does not modify any Ginkgo tests. It only changes manifest YAML files and pkg/util/util.go. The repository uses standard Go testing, not Ginkgo. Check is not applicable.
Test Structure And Quality	✅ Passed	No Ginkgo tests in PR. Repository uses standard Go testing, not Ginkgo. No new test files added or existing tests modified.
Microshift Test Compatibility	✅ Passed	PR does not add any new Ginkgo e2e tests. Changes are limited to Kubernetes YAML manifests and removal of unused Go code. Custom check for MicroShift test compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests added. PR modifies Kubernetes manifests and utility code only. Check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR does not introduce new scheduling constraints. Changes only modify container command logic for OVN-K compatibility. Pre-existing manifest topology concerns are outside PR scope.
Ote Binary Stdout Contract	✅ Passed	The OTE Binary Stdout Contract check is not applicable. This PR modifies the Cluster Network Operator, a standard Kubernetes operator, not an OTE test binary.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR does not add any new Ginkgo e2e tests. It modifies YAML manifest files and removes an unused Go utility function. The custom check is not applicable.
Title check	✅ Passed	The PR title accurately describes the primary change: removing the --enable-interconnect flag from OVN-K manifests while maintaining backward compatibility through runtime detection.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyrtapz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [kyrtapz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@kyrtapz: This pull request explicitly references no jira issue.

Details

In response to this:

We should drop the second commit once we sync the upstream changes into openshift/ovn-kubernetes.
It is required today so ovn-k works in both scenarios.

Summary by CodeRabbit

• Bug Fixes
• Improved compatibility with different OVN-Kubernetes image versions by making the interconnect feature conditional on runtime support detection. The system now probes for feature availability before enabling interconnect functionality, preventing startup failures when the feature is unavailable.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@kyrtapz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-ovn-ipsec-step-registry	c2241d4	link	true	/test e2e-ovn-ipsec-step-registry
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec	c2241d4	link	true	/test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/e2e-gcp-ovn	c2241d4	link	true	/test e2e-gcp-ovn
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp	c2241d4	link	true	/test e2e-metal-ipi-ovn-dualstack-bgp
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw	c2241d4	link	true	/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw
ci/prow/security	c2241d4	link	false	/test security
ci/prow/e2e-metal-ipi-ovn-ipv6	c2241d4	link	true	/test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-azure-ovn-upgrade	c2241d4	link	true	/test e2e-azure-ovn-upgrade
ci/prow/hypershift-e2e-aks	c2241d4	link	true	/test hypershift-e2e-aks

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.