OCPBUGS-63724: e2e:llc: skip test when no BM worker is found #1419
Conversation
|
@Tal-or can you extend this skip to other Contexts too ? (except configuration tests) |
Not sure which ones, could you please comment on the relevant contexts? |
|
Tal-or
force-pushed
the
skip_llc_test_vm
branch
from
a9d9ce2 to
4b03b24
Compare
The test no useful when the tested machines are all VMs. It will run efficiently on the d/s pipelines where actual BM workers are being tested. Signed-off-by: Talor Itzhak <titzhak@redhat.com>
Tal-or
force-pushed
the
skip_llc_test_vm
branch
from
4b03b24 to
453b7b7
Compare
|
/lgtm |
|
/retitle OCPBUGS-63724: e2e:llc: skip test when no BM worker is found |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@Tal-or: This pull request references Jira Issue OCPBUGS-63724, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
/test e2e-aws-ovn |
|
/retest |
|
@Tal-or: This pull request references Jira Issue OCPBUGS-63724, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@mrniranjan we need the verify label as well |
|
/verified by @mrniranjan |
openshift-ci-robot
added
the
verified
|
@mrniranjan: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Tal-or, yanirq The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/override ci/prow/e2e-aws-ovn |
|
@ffromani: Overrode contexts on behalf of ffromani: ci/prow/e2e-aws-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-4.20 |
|
@Tal-or: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@Tal-or: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@Tal-or: Jira Issue Verification Checks: Jira Issue OCPBUGS-63724 Jira Issue OCPBUGS-63724 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@Tal-or: new pull request created: #1422 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Fix included in accepted release 4.21.0-0.nightly-2025-11-03-191704 |
7 participants
The test isn't useful when the tested machines are all VMs. It will run efficiently on the d/s pipelines where an actual BM workers are being tested.