Skip to content

Conversation

@jmencak
Copy link
Contributor

@jmencak jmencak commented Nov 28, 2025

In classic clusters, the metrics client CA is provided via (not pod-mounted) ConfigMap. This is different in HyperShift, where the metrics client CA is provided via a volume mounted secret as a file.

This change reads the metrics client CA from the mounted file and also takes into account CA rotation.

Other changes:

  • Configure tlsConfig options even when metrics client CA bundle is not supplied

Resolves: OCPBUGS-55399

This change will need to be reverted on the HyperShift side once this merges.

In classic clusters, the metrics client CA is provided via (not
pod-mounted) ConfigMap.  This is different in HyperShift, where the
metrics client CA is provided via a volume mounted secret as a file.

This change reads the metrics client CA from the mounted file and
also takes into account CA rotation.

Other changes:
  - Configure tlsConfig options even when metrics client CA bundle is
    not supplied

Resolves: OCPBUGS-55399:
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 28, 2025
@openshift-ci-robot
Copy link
Contributor

@jmencak: This pull request references Jira Issue OCPBUGS-55399, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

In classic clusters, the metrics client CA is provided via (not pod-mounted) ConfigMap. This is different in HyperShift, where the metrics client CA is provided via a volume mounted secret as a file.

This change reads the metrics client CA from the mounted file and also takes into account CA rotation.

Other changes:

  • Configure tlsConfig options even when metrics client CA bundle is not supplied

Resolves: OCPBUGS-55399

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from MarSik and swatisehgal November 28, 2025 10:26
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2025
@openshift-ci-robot
Copy link
Contributor

@jmencak: This pull request references Jira Issue OCPBUGS-55399, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

In response to this:

In classic clusters, the metrics client CA is provided via (not pod-mounted) ConfigMap. This is different in HyperShift, where the metrics client CA is provided via a volume mounted secret as a file.

This change reads the metrics client CA from the mounted file and also takes into account CA rotation.

Other changes:

  • Configure tlsConfig options even when metrics client CA bundle is not supplied

Resolves: OCPBUGS-55399

This change will need to be reverted on the HyperShift side.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jmencak
Copy link
Contributor Author

jmencak commented Nov 28, 2025

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 28, 2025

@jmencak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants