-
Notifications
You must be signed in to change notification settings - Fork 118
OCPBUGS-55399:: Fix metrics for HyperShift #1438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
OCPBUGS-55399:: Fix metrics for HyperShift #1438
Conversation
In classic clusters, the metrics client CA is provided via (not
pod-mounted) ConfigMap. This is different in HyperShift, where the
metrics client CA is provided via a volume mounted secret as a file.
This change reads the metrics client CA from the mounted file and
also takes into account CA rotation.
Other changes:
- Configure tlsConfig options even when metrics client CA bundle is
not supplied
Resolves: OCPBUGS-55399:
|
@jmencak: This pull request references Jira Issue OCPBUGS-55399, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jmencak: This pull request references Jira Issue OCPBUGS-55399, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
@jmencak: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
In classic clusters, the metrics client CA is provided via (not pod-mounted) ConfigMap. This is different in HyperShift, where the metrics client CA is provided via a volume mounted secret as a file.
This change reads the metrics client CA from the mounted file and also takes into account CA rotation.
Other changes:
Resolves: OCPBUGS-55399
This change will need to be reverted on the HyperShift side once this merges.