OCPBUGS-66214: Add support for lscpu_check TuneD built-in

[jmencak]

This change adds support for lscpu_check TuneD built-in.

Other changes

• Drop the severity from ERROR to WARNING in execTuneDBuiltin()
• Be more specific what is the impact of calling unsupported TuneD built-in function

Resolves: OCPBUGS-66214

[openshift-ci-robot]

@jmencak: This pull request references Jira Issue OCPBUGS-66214, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This change adds support for lscpu_check TuneD built-in.

Other changes

• Drop the severity from ERROR to WARNING in execTuneDBuiltin()
• Be more specific what is the impact of calling unsupported TuneD built-in function

Resolves: OCPBUGS-66214

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jmencak]

I've manually verified this error no longer appears when using this CR on SNO:

apiVersion: tuned.openshift.io/v1
kind: Tuned
metadata:
  name: openshift-profile
  namespace: openshift-cluster-node-tuning-operator
spec:
  profile:
  - data: |
      [main]
      summary=Custom OpenShift profile
      include=openshift-node${f:lscpu_check:.:}
    name: openshift-profile
  recommend:
  - machineConfigLabels:
      machineconfiguration.openshift.io/role: "master"
    priority: 18
    profile: openshift-profile

[MarSik]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, MarSik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [MarSik,jmencak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ffromani]

/lgtm

[jmencak]

@liqcui , would you be able to provide pre-merge verification for this? It should be pretty easy, just create the manifest above on a regular cluster. Thank you!

[liqcui]

/verified by @liqcui

[openshift-ci-robot]

@liqcui: This PR has been marked as verified by @liqcui.

In response to this:

/verified by @liqcui

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jmencak]

This should go to 4.21.0
/label acknowledge-critical-fixes-only

[jmencak]

/retest

[openshift-ci]

@jmencak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@jmencak: Jira Issue Verification Checks: Jira Issue OCPBUGS-66214
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-66214 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

This change adds support for lscpu_check TuneD built-in.

Other changes

• Drop the severity from ERROR to WARNING in execTuneDBuiltin()
• Be more specific what is the impact of calling unsupported TuneD built-in function

Resolves: OCPBUGS-66214

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jmencak]

/cherry-pick release-4.20

[openshift-cherrypick-robot]

@jmencak: new pull request created: #1443

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.